I can't see how webform_system_breadcrumb_alter is useful.
The module breadcrumb builder does the job quite well and the only change I can see from the hook is the change of "Webform" to "Webforms" on video pages of the help section, which is an alteration of the module breadcrumb itself.
Moreover, this piece is not as clean and restrictive as it should and leads to performances issues and bugs (I receives an exception from Url::fromRouteMatch($route_match)->toString() because I contruct a RouteMatch object programmatically to build "non current" — and non webform related — breadcrumbs).

CommentFileSizeAuthor
#2 3152430-2.patch1.68 KBnicolasgraph

Comments

NicolasGraph created an issue. See original summary.

nicolasgraph’s picture

StatusFileSize
new1.68 KB

Here is the proposed patch.

nicolasgraph’s picture

Status: Active » Needs review
jrockowitz’s picture

Status: Needs review » Fixed

I committed the patch. Moving forward if we have issues with breadcrumbs we should add some test coverage.

  • NicolasGraph authored f86398d on 6.x
    Issue #3152430 by NicolasGraph: Useless breadcrumb altering
    

  • NicolasGraph authored f86398d on 8.x-5.x
    Issue #3152430 by NicolasGraph: Useless breadcrumb altering
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.