Thought about using the same method as menu generateIndexAndSort with a function

CommentFileSizeAuthor
#5 3151493.patch813 byteslarowlan
#2 3151493-2.patch1.34 KBviappidu

Comments

viappidu created an issue. See original summary.

viappidu’s picture

viappidu commented
StatusFileSize
new 3151493-2.patch1.34 KB

Patch created

Status: Needs review » Needs work

The last submitted patch, 2: 3151493-2.patch, failed testing. View results

akalata’s picture

akalata commented

Thanks, this works great! I'm not sure why the tests are failing, but we should also add tests for the sort.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new 3151493.patch813 bytes

Here's a much simpler approach

  • akalata committed 0cf35ea on 8.x-2.x authored by larowlan 
    Issue #3151493 by viappidu, larowlan: Order by $instance->weight
akalata’s picture

akalata commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.