D9 builds are currently failing due to missing core_version_requirement key in config_ignore_hook_test info file.

CommentFileSizeAuthor
#2 3150462-2.patch492 bytessuzymasri

Comments

suzymasri created an issue. See original summary.

suzymasri’s picture

suzymasri
Location Greece
commented
StatusFileSize
new 3150462-2.patch492 bytes

Patch attached.

mrpauldriver’s picture

mrpauldriver commented
Status: Active » Closed (duplicate)

Duplicated in #3131937: Add key 'core_version_requirement' (D9 preparation)

suzymasri’s picture

suzymasri
Location Greece
commented
Status: Closed (duplicate) » Needs review

@MrPaulDriver This issue is to include the "core_version_requirement" key on the 3.x branch, while #3131937: Add key 'core_version_requirement' (D9 preparation) is for 2.x.

3.x supports core ^8.8 || ^9 , therefore core key needs to be removed in favor of core_version_requirement.

jigarius’s picture

jigarius
Location Montréal
commented
Status: Needs review » Reviewed & tested by the community

Works. Looks good to me.

johnennew’s picture

johnennew commented

Agreed - this patch is needed, D9 explodes with an error about the test module even though its not enabled.

orlando.thoeny’s picture

orlando.thoeny
Location Switzerland 🇨🇭
commented

Sorry wrong issue: Ignore this comment

bryandenijs’s picture

bryandenijs
Primary language Dutch
commented

Thanks for the patch! It seems to be enough to make the module work with D9!

markdorison’s picture

markdorison
he/him
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Closing this as a duplicate of #3042661: Drupal 9 Deprecated Code Report as it has additional necessary changes for D9.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Closed (duplicate) » Reviewed & tested by the community

Reopening this issue since #3042661: Drupal 9 Deprecated Code Report is for the 2.x branch. This issue is about fixing D9 compatibility for the 3.x branch.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Title: D9 Readiness » [8.x-3.x] D9 Readiness
pcate’s picture

pcate commented

Looks like there are still failing D9 tests. Can anyone confirm these are un-related to D9 compatibility? If they are un-related, has an issue been created to resolve them?

mpotter’s picture

mpotter commented

Need to also remove the "core" tag from "config_ignore_hook_test.info.yml". This causes errors when running tests locally and might be related to the failing tests reported in #12.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Reviewed & tested by the community » Closed (outdated)

This was fixed in #3117694: Make all available tests pass.