June 15, 2020 - Meeting Agenda [#3149918]

Meeting Agenda

Introductions
Status
Issue updates and discussion
Where can people help this week?

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Minutes

Hello, welcome to this week’s Front-end theme Olivero meeting!• This meeting happens every Monday at 2pm GMT (10am ET)• There is no audio or video -- this meeting is chat only• The conversations for this meeting happen in threads0️⃣ If you’re attending this meeting, please let us know here and leave a comment in the meeting agenda issue so we can give you issue credit on d.o.: #3149918: June 15, 2020 - Meeting Agenda

Indrajith KB	Hello...
kishor_kolekar	hello. :wave:
kiran.kadam911	Hello
shaal	Hi!
cocoabean	Good morning!
brianperry	Hello!
nitesh624	Hi all
Rahul Kumar	Hello Everyone
Hansa	Hello :wave:
mherchel	Morning (and afternoons, and evenings)!
komal k	Hi..
proeung	Hello!
Ruchi kumari	Hello Everyone!
atul4drupal	Hello all
Webbeh (he/him)	Happy Monday, all!
Sagar	Hello!
himanshu_sindhwani	Hi a bit late, syncing now
andrewozone	attended late, but caught up on the threads!

1️⃣ Status updateOur path to beta is currently headed towards Drupal 9.1. #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

mtift (he/him)	Let's use this issue to discuss the overall status of the initiative in broad terms, and we'll save specific issue discussions for later threads.
mherchel	image.png
mherchel	I’m planning to tag the 3rd and final alpha tomorrow (beta1 will come after)
mherchel	Lots of work went into the issues above. I personally did a lot of work styling core’s layout builder layouts, and refactoring the primary nav to include support for route: and route:.
mherchel	it was a heavy lift, but I also found and fixed an IE bug in there
mherchel	In addition, core views grid layout is now responsive!
mherchel	at least in Olivero. I created a core issue to have those changes in the default views CSS
Webbeh (he/him)	Bravo on the issue to remediate that in Core as well.
mherchel	Thanks.. Not sure that’ll go through. having the layout be responsive means there’s no row wrapping divs
mherchel	however, in core there’s a UI to add classnames to that
mherchel	so :man-shrugging:
Indrajith KB	Do we supporting olivero to use as admin theme?
mherchel	Nope.
mherchel	But if the fix is easy enough, we might incorporate it
mherchel	That all being said, sometimes admin UI elements can “leak” into the front end (like vertical tabs etc)
mherchel	so, we need to support that
kostyashupenko	users permissions are not obvious sometimes :slightly_smiling_face: (edited)
mherchel	true
mtift (he/him)	At some point, we will need a list of FAQs somewhere, with common questions about admin theme, color module, etc
mherchel	I volunteer Matthew Tift to do that!
proeung	@mtift (he/him) Great idea! We should add a FAQs page here - https://www.drupal.org/docs/contributed-themes/olivero
mherchel	:smile:
proeung	I can help out with this effort. :+1:
mherchel	yay!
mtift (he/him)	I probably could look back at old meeting notes to see what questions come up regularly
mtift (he/him)	And Slack, like questions about the debugging menu
mtift (he/him)	anyway...
mtift (he/him)	no need to get into that here

2️⃣ Issue updates and status

mtift (he/him)	Here is the place to discuss issues that need some extra attention
Indrajith KB	Am like to point out Form element related issues (Like CKEditor background color, Radio button state behaviours)
proeung	We have 4 PostCSS plugins that will need to be discussed and get approval to be in Core build process. Any idea on how we can expedite these conversations?
mherchel	We could use social media to ask people to comment in there
mherchel	#3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta is a priority for putra and I
proeung	Great idea! @mherchel I think social media is a good place to open this up to a larger group, however, I highly recommend everyone here to comment in those issues as well. :slightly_smiling_face:
nitesh624	@mherchel any input on language switcher styling #3127588: Theme Olivero's language switcher
mherchel	My thought on that is we need to decide where to put it first. We currently do not have designs for it in the header. It could go in the sidebar
mherchel	I need to get on our designers. There’s a number of tasks that need their attention
atul4drupal	#3144398: Should we make accommodations for contrib modules within this core theme
atul4drupal	This too needs a consideration as to what contrib modules are we planning to have considered
atul4drupal	if at all we are thinking of extending Olivero at this time
himanshu_sindhwani	I am trying various form elements here #3149714: Olivero: Audit form items within settings tray for visual inconsistencies and also added one comment for multipe select items, will update the comments for other elements too
himanshu_sindhwani	#3149863: Olivero: Modal dialog buttons not aligned (for example, in the "Leave preview" dialog) this also needs to get some lights
komal k	#3151586: Remove bullet of link action Need more steps to reproduced this

3️⃣ Where can people help this week?

mtift (he/him)	Share your suggestions here if you got 'em
mherchel	I want to concentrate on accessibility and coding standards this week
mherchel	Some of the CSS/JS comments are not in the correct format
mherchel	Also our JS queries a lot of standard CSS selectors I believe that per coding standards the JS should only query CSS classes that have a js- prefix. Need to confirm that though.
Indrajith KB	Some suggestions here from my sideUpdate figma designUpdate development document (People are refering this to createn patch that's why they are not adding DIST file to the patch)Add both SRC and DIST filesCheck CSS and JS lintingTry to follow proper nesting styles.(edited)
cocoabean	Comments “audit” is definitely something that anyone can contribute to!
mherchel	whats a comments audit?
cocoabean	Oh you had said that the comments in CSS/JS are not in correct format
mherchel	oh yeah!
mherchel	sorry! I was thinking Drupal comments :smile:
cocoabean	I figured we are auditing code :slightly_smiling_face:
mherchel	we are :slightly_smiling_face:

Participants:

Indrajith KB, kishor_kolekar, kiran.kadam911, shaal, cocoabean, brianperry, nitesh624, Rahul Kumar, Hansa, mherchel, komal k, proeung, Ruchi kumari, atul4drupal, Webbeh (he/him), Sagar, himanshu_sindhwani, andrewozone, mtift (he/him), kostyashupenko