Problem/Motivation

Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 9.

To read more about this effort by the Drupal Association, please read: Accelerating Drupal 9 module and theme readiness with automated patches

Periodically patches will be added to this issue that remove Drupal 9 deprecations. To stop further patches from being posted simply close this issue(any status besides Active, Needs Review or Needs work) or remove the "ProjectUpdateBotD9" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open(status of Active, Needs Review or Needs work) and the "ProjectUpdateBotD9" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.

    As the Drupal Rector project improves and is able to fix more deprecations the patches posted here will cover more of the deprecations in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecations but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD9" from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again simply add back the "ProjectUpdateBotD9" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful they can simply close this issue(any status besides Active, Needs Review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 9 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear,  use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new343 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 9 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 9! 🎉
This patch updates the info.yml file for Drupal 9 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 9 compatibility fixes as they become available in Drupal-Rector.

Debug info

Bot run #1478

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 0.12.3
  2. palantirnet/drupal-rector: 0.5.6
  3. rector/rector-prefixed: v0.7.29

markus_petrux made their first commit to this issue’s fork.

mighty_webber’s picture

Issue summary: View changes

This still needs to be modified before being merged in or looked at. I am trying to create a fork of the project but gitlab will not let me and keeps throwing an error. Can I please be added to the maintainers of this project so that I can contribute to getting this D9 Compat please?

scorbine’s picture

Used GitPod for testing with Drupal 9.2.

  • Installed module with no issues.
  • No issues logged in Log Messages.
  • Status Report page has no issues.

What operating system were you using?
Mac OS

What PHP version are you using (see https://www.drupal.org/i/3275810#confirm-php-version)?
8.0.16

What version of Composer are you using (see https://www.drupal.org/i/3275810#confirm-composer-version)?
Composer version 2.3.5 2022-04-13 16:43:00

lreynaga’s picture

Status: Needs review » Reviewed & tested by the community

I reviewed the patch locally and it could not be applied, the change in the patch is already in the main branch: https://git.drupalcode.org/project/twig_link_attributes/-/blob/8.x-1.x/t...

I also tried running drupal-rector against this project and it found nothing else that could be addressed. I'll mark this as RTBC now also given @scorbine did a through review already, and if anything this could be closed now.

mighty_webber’s picture

Status: Reviewed & tested by the community » Closed (cannot reproduce)

Closing - Old ticket that is resolved with 2.0.x

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.