Problem/Motivation

Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 9.

To read more about this effort by the Drupal Association, please read: Accelerating Drupal 9 module and theme readiness with automated patches

Periodically patches will be added to this issue that remove Drupal 9 deprecations. To stop further patches from being posted simply close this issue(any status besides Active, Needs Review or Needs work) or remove the "ProjectUpdateBotD9" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open(status of Active, Needs Review or Needs work) and the "ProjectUpdateBotD9" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.

    As the Drupal Rector project improves and is able to fix more deprecations the patches posted here will cover more of the deprecations in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecations but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD9" from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again simply add back the "ProjectUpdateBotD9" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful they can simply close this issue(any status besides Active, Needs Review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 9 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear,  use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

Issue fork jcarousel-3147854

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new2.25 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 9 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 9.

Currently Drupal-Rector, version 0.5.6, cannot fix all Drupal 9 compatibility problems.

This patch does not update the info.yml file for Drupal 9 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 9 compatibility fixes as they become available in Drupal-Rector.

Debug info

Bot run #1478

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 0.12.3
  2. palantirnet/drupal-rector: 0.5.6
  3. rector/rector-prefixed: v0.7.29
piyushsms91’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Related issues: +#3153442: Drupal Check - Drupal 9 Compatibility Issue
StatusFileSize
new1.32 KB

Hi All,
Drupal 9 module compatibility reviewed it working fine, I have review the patch "jcarousel.4.0.rector.patch.txt". Now I have updated the patch with including .info file changes.

vishalgala’s picture

#3 verified and working fine for me.

imclean’s picture

Version: 8.x-4.0 » 8.x-5.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new1.94 KB

#3087864-5: Offering to maintain jCarousel,

8.5 will have Drupal 9 support shortly.

chegor’s picture

StatusFileSize
new355 bytes

Rerolled patch for latest 5.x

Can we commit it to have support for Drupal 9?

38,518 sites report using this module but it still have to Drupal 9 support.

guilhermevp’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new19.76 KB
new4.97 KB

Patch applies cleanly and works as intended.

lorenzs’s picture

Status: Reviewed & tested by the community » Needs work
Related issues: +#3100150: Drupal 9 Code Report

See https://www.drupal.org/project/jcarousel/issues/3100150
Module is still incompatible with Drupal 9. If we ignore the drush part it might be fixed easily.

sunil.drupal made their first commit to this issue’s fork.

sharique’s picture

Status: Needs work » Needs review
StatusFileSize
new8.32 KB

I've removed the drush command and added libraries to composer.json file.

selinav’s picture

When the version for drupal 9 will be available if it well works ?
Thank you for your help.

santhosh-kumar-rengasamy’s picture

StatusFileSize
new9.92 KB

Ignore this patch, not uploaded correctly.

santhosh-kumar-rengasamy’s picture

StatusFileSize
new9.92 KB

There is a letter case issue in the composer package name, I have updated those consolidated changes in this patch.

Please review this patch.

Szeke made their first commit to this issue’s fork.

santhosh-kumar-rengasamy’s picture

StatusFileSize
new10.21 KB

Added a small change in the ajax element selector.

For the issue: https://www.drupal.org/project/jcarousel/issues/3250806

kazah’s picture

Thank you, Santhosh-Kumar-Rengasamy!

Drupal version 9.2.8
Applying a patch #15 - the carousel started working.
Ajax works but need to select the jcarousel option in pager.

When you click on the next slide, the carousel displays the element, but the following errors are displayed in the console:

1. Uncaught TypeError: settings.dialog is undefined (dialog.ajax.js:27:27)
2. Uncaught TypeError: right-hand side of 'in' should be an object, got undefined (photoswipe.jquery.js:33:13)

santhosh-kumar-rengasamy’s picture

@kazah

Issue 1 is a core issue, Please refer this issue: https://www.drupal.org/project/drupal/issues/2498915#comment-14301350

kazah’s picture

Thank you!

voleger’s picture

Version: 8.x-5.x-dev » 6.0.x-dev

voleger’s picture

Rebased patch against 6.0.x

voleger’s picture

  • voleger committed 6ff2a97 on 6.0.x
    Issue #3147854 by Santhosh-Kumar-Rengasamy, voleger, Project Update Bot...
voleger’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.