Problem/Motivation

Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 9.

To read more about this effort by the Drupal Association, please read: Accelerating Drupal 9 module and theme readiness with automated patches

Periodically patches will be added to this issue that remove Drupal 9 deprecations. To stop further patches from being posted simply close this issue(any status besides Active, Needs Review or Needs work) or remove the "ProjectUpdateBotD9" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open(status of Active, Needs Review or Needs work) and the "ProjectUpdateBotD9" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.

    As the Drupal Rector project improves and is able to fix more deprecations the patches posted here will cover more of the deprecations in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecations but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD9" from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again simply add back the "ProjectUpdateBotD9" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful they can simply close this issue(any status besides Active, Needs Review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 9 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear,  use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

Issue fork exif-3147406

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new2.55 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 9 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 9.

Currently Drupal-Rector, version 0.5.6, cannot fix all Drupal 9 compatibility problems.

This patch does not update the info.yml file for Drupal 9 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 9 compatibility fixes as they become available in Drupal-Rector.

Debug info

Bot run #1478

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 0.12.3
  2. palantirnet/drupal-rector: 0.5.6
  3. rector/rector-prefixed: v0.7.29
damienmckenna’s picture

Issue summary: View changes
Parent issue: » #3182081: Plan for Exif 8.x-2.3
nick hope’s picture

Priority: Normal » Major
StatusFileSize
new5.01 KB

The automated patch #2 does apply and does fix a couple of things for D9-compatibility, but is far from complete.

This patch incorporates these fixes:
- patch #2 from here.
- patch #4 from here (that makes the configuration accessible).
- patch #6 from here (which fixes the uriScheme error on save).
- a couple of other deprecations that I found when studying the code.

The Upgrade Status module is still giving me 25 warnings "Call to deprecated function drush_log()" for exif.drush.inc. I took a quick look at that but it doesn't look as obvious as it might seem to fix, and I'm not sure how important it is, so I left it for now.

In the meantime, hopefully this can allow us to get an updated dev that works.

nickdickinsonwilde’s picture

Status: Needs review » Needs work

doesn't apply on current dev

nickdickinsonwilde’s picture

Status: Needs work » Needs review
vuil’s picture

@maintainers,
Any updates, commits and new D9 stable version release?

randallnet’s picture

StatusFileSize
new4.58 KB

I've fixed the issues with patch #4 and excluded the changes from this patch https://www.drupal.org/project/exif/issues/3172682#comment-14095702 since that was applied without issues.

jasonmcd’s picture

StatusFileSize
new49.93 KB

Thank Randallnet! This patch allowed the EXIF module to run on my Drupal 9.2.2 test server. However, the sample page doesn't output metadata, so I don't think it's fully working on my site. I'm not a programmer so I dunno what to do about this.

vuil’s picture

Status: Needs review » Reviewed & tested by the community

It's fine.

damienmckenna’s picture

Title: Automated Drupal 9 compatibility fixes » Automated Drupal 9 compatibility fixes for EXIF 8.x-2.x
vgutekunst’s picture

#11 i dont understand exactly. Does it work with D9 now or not?

vuil’s picture

The MR of #12 is RTBC.

damienmckenna’s picture

Status: Reviewed & tested by the community » Fixed

Committed. Thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.