Drupal 9 Readiness

Updated the patch.

Fixed the below issues:
--------------------------------------------------------------------------------
Switch Page Theme
Scanned on Fri, 06/05/2020 - 08:15.

2 errors found. 1 warning found.

modules/contrib/switch_page_theme/src/Form/SwitchPageThemeSettingForm.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├─────────┼──────┼──────────────────────────────────────────────────────────┤
│ Fix now │ 146 │ Call to deprecated function system_list(). Deprecated in │
│ │ │ drupal:8.7.0 and is removed from drupal:9.0.0. Use │
│ │ │ \Drupal::service('theme_handler')->listInfo() instead. │
│ │ │ │
└─────────┴──────┴──────────────────────────────────────────────────────────┘

modules/contrib/switch_page_theme/src/Theme/PageThemeNegotiator.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 88 │ Parameter $pathAlias of method │
│ │ │ Drupal\switch_page_theme\Theme\PageThemeNegotiator::__constr │
│ │ │ uct() has typehint with deprecated interface │
│ │ │ Drupal\Core\Path\AliasManagerInterface. Deprecated in │
│ │ │ drupal:8.8.0 and is removed from drupal:9.0.0. Use │
│ │ │ Drupal\path_alias\AliasManagerInterface. │
│ │ │ │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/switch_page_theme/switch_page_theme.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check │ 0 │ Add core_version_requirement: ^8 || ^9 to │
│ manually │ │ modules/contrib/switch_page_theme/switch_page_theme.info.yml │
│ │ │ to designate that the module is compatible with Drupal 9. │
│ │ │ See https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

The DomainLoader service was deprecated for Drupal 9. Use DomainStorage instead.

See patch in #3156842: Domain loader doesn't exist in Drupal 8.

Updated patch #3 as per suggested in #4, please review.

Looks good to me.
Tested both:
drupal-9-3145213-2.patch
3145213-5.patch

When can we expect a stable release for this module ported for Drupal 9,Can we have some timelines

Patch 5 saved me on a production D9 site. I would love to see an official release come out for D9!

[trying to write calmly and politely]Please upgrade this module for Drupal 9.[/trying to write calmly and politely] Thanks.

It actually seems that the 1.x branch has further commits than the 3.x (all commits from 3.x are in 1.x), so I'm rolling the patch for the 1.x branch, which already had some of the elements here included into that branch.

The patch for 3.x works so I'm leaving this as RTBC.
This patch is for 1.x branch, where the patch does not apply and the maintenance of the module seems to be focused on.

Thanks for the patch, @fjgarlin

Porting this patch to 1.x branch and releasing Drupal 9 support soon.

When is this going to be released officially?

+1 please release the version for Drupal 9 we have a requirement with multiple roles having different themes on multiple urls. This module is exactly what we need it would be great if we can get a release of this now?

Thanks

In the same case :)
Thanks for this great module !

+1 For needing a Drupal 9 version of this module!

@ashish-deynap, Comment #12 from Feb 2021 you said.

Porting this patch to 1.x branch and releasing Drupal 9 support soon.

Any update on when a 1.0.0 tag with the D9 support could be tagged and released?

Thanks!

I've created #3246070: Release Switch Page Theme version 4.0.0 with Drupal 9 support for the follow-up task of cutting a release version with D9 support.