Problem/Motivation

Drupal 9 requires pulling the 1.x-dev version in composer.json

On #3145213-12: Drupal 9 Readiness @ashish-deynap commented on Feb 2021:

Porting this [Drupal 9 readiness] patch to 1.x branch and releasing Drupal 9 support soon.

Any update on when a 4.0.0 tag with the D9 support could be released?

Thank you.

Steps to reproduce

Proposed resolution

Create a 4.0.0 tag and release it.

Consider also committing the d9 compatibility fixes from #3145213: Drupal 9 Readiness to the 2.x and 3.x branches.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#13 Screen Shot 2021-11-29 at 10.00.31 PM.jpg331.61 KBjwilson3

Comments

jwilson3 created an issue. See original summary.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Issue summary: View changes
danthorne’s picture

danthorne
Primary language English
Location Devon, UK
commented

Would be good to get this release before D8 eol on Tuesday

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Title: 1.1 release for Drupal 9 support » Release 1.1 Switch Page Theme with Drupal 9 support before D8 EOL
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Title: Release 1.1 Switch Page Theme with Drupal 9 support before D8 EOL » Release Switch Page Theme version 1.1 with Drupal 9 support before D8 EOL

Totally agree. I should have been more explicit -- the D8 EOL is exactly why I filed this issue.

sagesolutions’s picture

sagesolutions commented

Any update on this? Drupal 8 is now EOL

guypaddock’s picture

guypaddock commented
Title: Release Switch Page Theme version 1.1 with Drupal 9 support before D8 EOL » Release Switch Page Theme version 1.1 with Drupal 9 support
Priority: Normal » Major
sagesolutions’s picture

sagesolutions commented
Title: Release Switch Page Theme version 1.1 with Drupal 9 support » Release Switch Page Theme version 2.0.0 with Drupal 9 support
Issue summary: View changes
sagesolutions’s picture

sagesolutions commented
Title: Release Switch Page Theme version 2.0.0 with Drupal 9 support » Release Switch Page Theme version 4.0.0 with Drupal 9 support
Issue summary: View changes
sagesolutions’s picture

sagesolutions commented

Since the highest branch is 3.x, the Drupal 9 version needs to be higher than that, so please make a 4.0.0 tag with Drupal 9 support

alienzed’s picture

alienzed commented

Anything I can do to help move this along? This is a blocker in my Drupal 9 upgrade process!

dunin’s picture

dunin commented

I'd love to get that too.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
StatusFileSize
new Screen Shot 2021-11-29 at 10.00.31 PM.jpg331.61 KB

Since the highest branch is 3.x, the Drupal 9 version needs to be higher than that, so please make a 4.0.0 tag with Drupal 9 support

Branches are a mess on this module.

  • The network graph of the Switch Page Theme's git repository, showsthat 8.x-1.x is actually ahead of all other branches, including 8.x-2.x and 8.x-3.x. Here is a snapshot in time:

    It is almost as if 8.x-1.x is being used as if it were a mainline development (aka "master") branch — but this is sadly not the current Drupal branching model.

  • There are other unexpected things going on in the release tags as well, whereby 1.0 == 3.3-alpha1 and 2.0 == 3.0-alpha1.

Perhaps the approach here could be the following:

  1. Create a 4.0.x branch and tag a 4.0.0 release, both located the commit where 8.x-1.x currently is.
  2. Set the 4.0.x branch as the default branch in Drupal UI (Project > Edit > Default Branch).
  3. Delete 8.x-1.x, 8.x-2.x, and 8.x-3.x branches. eg git push origin :8.x-1.x :8.x-2.x :8.x-3.x (Sidenote: Can release branches be deleted once they're not the "default branch" in Drupal anymore???)
  4. Follow-up issue to clean up tag duplication. (Sidenote: can tags be deleted from drupal.org if they have releases?)
alienzed’s picture

alienzed commented

Does the maintainer need to do this or can anyone? I'll take a stab at it if I am allowed...

codesmith’s picture

codesmith
Location San Francisco
commented

I just tried https://www.drupal.org/project/theme_switcher which has Drupal 9 support and it's working fine for me. So I'm switching to that module.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

Does the maintainer need to do [steps outlined in #13] or can anyone?

This must be done by a maintainer.

pstewart’s picture

pstewart commented

As the project appears to be abandoned, is there anyone following this issue willing to take over as a maintainer / co-maintainer? If so then we should kick-start the process as per https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... . If not I'm willing to be a temporary co-maintainer to help get this release done, however I don't have any spare capacity beyond that so if there's a more suitable candidate then by all means go ahead!

sagesolutions’s picture

sagesolutions commented

I ended up switching to https://www.drupal.org/project/theme_switcher which seems to be a bit more robust and well maintained. Maybe this project should be abandoned and redirect people to the theme_switcher module instead?

pstewart’s picture

pstewart commented

I too have now switched to theme_switcher, replacing my two switch_page_theme rules (one for content, one for the content's admin pages) with a single theme_switcher rule which does both, which was very straightforward. I guess there may be some people with more complex rule sets that would benefit from a D9 release of this module in favour of having to rewrite their rulesets, otherwise switching to theme_switcher is definitely the away to go.

nicolas bouteille’s picture

nicolas bouteille commented

made the switch as well thx

Dharmendra.s’s picture

Dharmendra.s commented
Status: Active » Fixed

Update the release for drupal 9 as well as drupal 10.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.