Hero block display based on path is too fragile

Hi there, looks like i've discovered related issue, PR with fixes is here: https://github.com/goalgorilla/open_social/pull/1915

PR was merged and will be included in release 8.5

We reverted PR above in this one: https://github.com/goalgorilla/open_social/pull/1960, because it caused regression.
To fix issue with missing hero for custom content types the same approach as in Social Book module might be used in config override:

    // Set hero title block for discussion content type.
    $config_names = [
      'block.block.socialbase_pagetitleblock',
      'block.block.socialblue_pagetitleblock',
    ];
    foreach ($config_names as $config_name) {
      if (in_array($config_name, $names)) {
        $config = \Drupal::service('config.factory')->getEditable($config_name);
        $bundles = $config->get('visibility.node_type.bundles');
        $bundles['discussion'] = 'discussion';
        $overrides[$config_name] = ['visibility' => ['node_type' => ['bundles' => $bundles]]];
      }
    }

Well, despite saying that the issue has been resolved, I just tested this in version 8x.9 and 10.2.0 using the title:

"edit, Add, and Delete still cause duplicate headers and Hero's!"

and it still persists

I do not know why this issue has been closed!

The issue of duplicate Hero Blocks being triggered by having 'add', 'edit', and 'delete' in the title still persists in social-11.3.2

Why has this been marked: Closed (works as designed)?

Re-opening, not sure why it is marked as works as designed. The PR mentioned was reverted, not fixed.

I have created a PR that should fix this issue: https://github.com/goalgorilla/open_social/pull/2968

This will be available in 11.4.0-beta2 onwards.

Cudos!

And for the indoctrinated, what did it take to fix this long standing issue, if I may ask?

My users would often use the word "Edit" or "Editor" in titles (as one example) and were often baffled by the results thinking they had done something wrong!