The module will sent a notification message to slack once the mentioned entity is created/updated/deleted.

Project link

https://www.drupal.org/project/notify_to_slack

Git instructions

git clone --branch 8.x-2.x https://git.drupalcode.org/project/notify_to_slack.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-notify_to_slac...

Comments

Lal_ created an issue. See original summary.

avpaderno’s picture

Issue summary: View changes

Thank you for applying! I added the PAReview checklist link.

Remember to change status, when the project is ready for review, as in this queue Active means Don't review yet the project I am using for this application.

pratik_kamble’s picture

Status: Active » Needs review
avpaderno’s picture

Status: Needs review » Active

This is an application created by Lal_, so it must be Lal_ to change status.

Lal_’s picture

Status: Active » Needs review

Didn't knew about the status....

shaktik’s picture

Kindly fix below warning.

Review of the 8.x-2.x branch (commit 71059a6):

  • The notify_to_slack.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     14 | WARNING | Line exceeds 80 characters; contains 106 characters
     32 | WARNING | Line exceeds 80 characters; contains 92 characters
     40 | WARNING | Line exceeds 80 characters; contains 137 characters
     41 | WARNING | Line exceeds 80 characters; contains 131 characters
    --------------------------------------------------------------------------
    
    Time: 1.83 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Lal_’s picture

Its fixed now

shaktik’s picture

Hi,

Still have some issue.

FILE: .../notify_to_slack/notify_to_slack.module
----------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------
 23 | ERROR   | [x] Expected one space after the comma, 0 found
 24 | ERROR   | [x] Case breaking statements must be followed by a
    |         |     single blank line
 25 | WARNING | [ ] Code after RETURN statement cannot be executed
 25 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 6
 28 | ERROR   | [x] Expected 1 blank line after function; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 177ms; Memory: 8Mb
Lal_’s picture

fixed those too

ankush_03’s picture

Pareview still showing warnings :

Review of the 8.x-2.x branch (commit 71059a6):
The notify_to_slack.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
14 | WARNING | Line exceeds 80 characters; contains 106 characters
32 | WARNING | Line exceeds 80 characters; contains 92 characters
40 | WARNING | Line exceeds 80 characters; contains 137 characters
41 | WARNING | Line exceeds 80 characters; contains 131 characters
--------------------------------------------------------------------------

Time: 1.83 secs; Memory: 6Mb

Lal_’s picture

Looks like you branch is behind few commits please check

klausi’s picture

Status: Needs review » Fixed

All looking good to me after a code review.

Thanks for your contribution, Abhishek!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.