Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 May 2020 at 12:47 UTC
Updated:
27 Jun 2020 at 12:34 UTC
Jump to comment: Most recent
Comments
Comment #2
avpadernoThank you for applying! I added the PAReview checklist link.
Remember to change status, when the project is ready for review, as in this queue Active means Don't review yet the project I am using for this application.
Comment #3
pratik_kambleComment #4
avpadernoThis is an application created by Lal_, so it must be Lal_ to change status.
Comment #5
Lal_Didn't knew about the status....
Comment #6
shaktikKindly fix below warning.
Review of the 8.x-2.x branch (commit 71059a6):
hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .This automated report was generated with PAReview.sh, your friendly project application review script.
Comment #7
Lal_Its fixed now
Comment #8
shaktikHi,
Still have some issue.
Comment #9
Lal_fixed those too
Comment #10
ankush_03Pareview still showing warnings :
Review of the 8.x-2.x branch (commit 71059a6):
The notify_to_slack.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
14 | WARNING | Line exceeds 80 characters; contains 106 characters
32 | WARNING | Line exceeds 80 characters; contains 92 characters
40 | WARNING | Line exceeds 80 characters; contains 137 characters
41 | WARNING | Line exceeds 80 characters; contains 131 characters
--------------------------------------------------------------------------
Time: 1.83 secs; Memory: 6Mb
Comment #11
Lal_Looks like you branch is behind few commits please check
Comment #12
klausiAll looking good to me after a code review.
Thanks for your contribution, Abhishek!
I updated your account so you can opt into security advisory coverage now.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.