When using database cache on an Percona XtraDB cluster Truncate's are quite blocking. This means all requests for the cache will wait for the tabel to finish.

When a SST (an initial sync to a new node) is running this can result in waiting for a lock indefinitely which means the sync will fail and the cluster will go down. Other than changing the caching backend to another service, we think not allowing TRUNCATE will aliviate the issues at least. Then we can at least be sure deploying multiple Drupal sites will not result in unfortunate issues where you run into a deadlock situation.

Not too sure what the proper way to fix this would be, but i think removing the possibility for TRUNCATE is at least a start.

CommentFileSizeAuthor
#20 3143562-20.patch916 bytescasey
#17 interdiff_3143562_11-17.txt188 bytesankithashetty
#17 3143562-17.patch1.25 KBankithashetty
#11 3143562-11.patch1007 bytescasey
#10 3143562-10.patch1.4 KBcasey
#7 3143562-7.patch1012 bytescasey
#4 never-use-TRUNCATE-d7-3143562-4.patch1.43 KBdagomar
#2 3143562-never-use-TRUNCATE-but-always-use-DELETE-FROM.patch1.74 KBbbrala
0001-Never-use-TRUNCATE-but-always-use-DELETE-FROM.patch1.74 KBbbrala

Issue fork drupal-3143562

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bbrala created an issue. See original summary.

bbrala’s picture

bbrala
Location Netherlands
commented
StatusFileSize
new 3143562-never-use-TRUNCATE-but-always-use-DELETE-FROM.patch1.74 KB
casey’s picture

casey commented
Related issues: +#1839998: TruncateQuery implemented as "DELETE FROM" in MySQL and SQLite, but not PostgreSQL, causing nefarious table locking, +#2222635: Waiting for table metadata lock on cache_field table
dagomar’s picture

dagomar commented
StatusFileSize
new never-use-TRUNCATE-d7-3143562-4.patch1.43 KB

This problem also occurs on Drupal 7 sites. Adding a patch.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented

Also applies to AWS Aurora clusters which are probably similar to XtraDB clusters.

Doing things like adding fields would take 60+ seconds. With patch <10s average 5s.

AWS Aurora 2.0 (MySQL 5.7-compatible)

casey’s picture

casey commented
Version: 8.9.x-dev » 9.1.x-dev
StatusFileSize
new 3143562-7.patch1012 bytes

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

casey’s picture

casey commented
StatusFileSize
new 3143562-10.patch1.4 KB

Oops, the previous patch was not targeting the mysql driver (for which the driver specific Truncate handler was removed in #3124354: Remove unnecessary classes from the database drivers)

casey’s picture

casey commented
StatusFileSize
new 3143562-11.patch1007 bytes

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

steinmb’s picture

steinmb commented
Status: Active » Needs review

Let's see if we still are green

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

CI failures for #11

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Needs work » Needs review
StatusFileSize
new 3143562-17.patch1.25 KB
new interdiff_3143562_11-17.txt188 bytes

Not sure if this is the fix to CI errors, but think it'll work...

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs issue summary update, +Needs tests

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

This could use an issue summary update using the default issue template. What's the proposed solution? What's the remaining tasks? Example this will need a test case to show the issue

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

casey’s picture

casey commented
StatusFileSize
new 3143562-20.patch916 bytes

Reroll for D11.2 and up

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.