D9 tests are failing due to a PHPUnit deprecation: https://www.drupal.org/pift-ci-job/1697338

This means, however, we'd have to drop Drupal 8.7 support

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman’s picture

Status: Active » Needs review
StatusFileSize
new20.97 KB

Contains patch for dropping 8.7 and fixing PHPUnit method.

Status: Needs review » Needs work

The last submitted patch, 3: using_assertnotconta-3139833-2.patch, failed testing. View results

mglaman’s picture

This gets us to just random failures 8.8. But we'll need to commit the 8.7 support drop. At least we know it's still compatible and just PHPUnit problems.

mglaman’s picture

Status: Needs work » Needs review
StatusFileSize
new4.81 KB

Support for 8.7 was dropped, here's a reroll without those changes.

Status: Needs review » Needs work

The last submitted patch, 6: using_assertnotconta-3139833-6.patch, failed testing. View results

mglaman’s picture

The failures are legit on assertStringNotContainsString.

In the compatibility trait:

  /**
   * Forward compatibility for assertStringNotContainsString.
   */
  public static function assertStringNotContainsString($needle, $haystack, $message = '') {
    static::assertNotContains((string) $needle, (string) $haystack, $message);
  }

So we're passing arrays as the haystack somewhere.

mglaman’s picture

Status: Needs work » Needs review
StatusFileSize
new2.26 KB

Okay, assertNotContains is not entirely deprecated. Just passing it a string and not an array of strings is deprecated.

mglaman’s picture

Title: Using assertNotContains() with string haystacks is deprecated » Using assertNotContains() and assertContains() with string haystacks is deprecated

Expanding to fix assertContains string haystacks for D9

mglaman’s picture

StatusFileSize
new13.13 KB
new14.86 KB

This adds fixes for assertContains to D9

mglaman’s picture

  • mglaman committed 2520240 on 8.x-2.x
    Issue #3139833 by mglaman: Using assertNotContains() and assertContains...
mglaman’s picture

Status: Needs review » Fixed

Fixed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.