Closed (fixed)
Project:
Commerce Core
Version:
8.x-2.x-dev
Component:
Tests
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 May 2020 at 16:20 UTC
Updated:
6 Jun 2020 at 20:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mglamanBlocked on #3139847: Drop Drupal 8.7 support, minimum of 8.8.x
Comment #3
mglamanContains patch for dropping 8.7 and fixing PHPUnit method.
Comment #5
mglamanThis gets us to just random failures 8.8. But we'll need to commit the 8.7 support drop. At least we know it's still compatible and just PHPUnit problems.
Comment #6
mglamanSupport for 8.7 was dropped, here's a reroll without those changes.
Comment #8
mglamanThe failures are legit on assertStringNotContainsString.
In the compatibility trait:
So we're passing arrays as the haystack somewhere.
Comment #9
mglamanOkay,
assertNotContainsis not entirely deprecated. Just passing it a string and not an array of strings is deprecated.Comment #10
mglamanExpanding to fix assertContains string haystacks for D9
Comment #11
mglamanThis adds fixes for assertContains to D9
Comment #12
mglamanThe remaining failures are due to #3121071: Replace theme_inline_entity_form_entity_table() with twig template
Comment #14
mglamanFixed!