Closed (fixed)
Project:
Commerce Core
Version:
8.x-2.x-dev
Component:
Other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 May 2020 at 16:22 UTC
Updated:
6 Jun 2020 at 19:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mglamanComment #5
mglamanThis removes some BC layers for 8.7 and 8.8+ suport
Comment #6
mglamanLooks like I missed \Drupal\commerce\EntityManagerBridgeTrait
EDIT: \Drupal\views\FieldAPIHandlerTrait exists, which does somewhat the same thing. Our trait ensures the bundle manager info. Maybe it's best to keep this around, it's not hurting us. I'll try to do more review to see if we can remove before ^9
Comment #7
mglamanEntityManagerBridgeTrait touches Views plugins, which don't seem to have standard dependency injection. I'd rather tackle that elsewhere than bog down the D9 compatibility process.
I opened: #3140953: Deprecate or remove the EntityManagerBridgeTrait for handling that trait.
Comment #9
mglaman8.7 is now dropped.