We should drop support for Drupal 8.7. June 3, 2020 will be the end of security support for Drupal 8.7 (https://www.drupal.org/core/release-cycle-overview).

This also helps us support Drupal 9 in our next release. See #3139833: Using assertNotContains() and assertContains() with string haystacks is deprecated

Comments

mglaman created an issue. See original summary.

mglaman’s picture

Status: Active » Needs review
StatusFileSize
new16.16 KB

mglaman credited bojanz.

mglaman credited jsacksick.

mglaman’s picture

StatusFileSize
new2.16 KB
new18.32 KB

This removes some BC layers for 8.7 and 8.8+ suport

mglaman’s picture

Looks like I missed \Drupal\commerce\EntityManagerBridgeTrait

EDIT: \Drupal\views\FieldAPIHandlerTrait exists, which does somewhat the same thing. Our trait ensures the bundle manager info. Maybe it's best to keep this around, it's not hurting us. I'll try to do more review to see if we can remove before ^9

mglaman’s picture

EntityManagerBridgeTrait touches Views plugins, which don't seem to have standard dependency injection. I'd rather tackle that elsewhere than bog down the D9 compatibility process.

I opened: #3140953: Deprecate or remove the EntityManagerBridgeTrait for handling that trait.

  • mglaman committed e4a96cd on 8.x-2.x
    Issue #3139847 by mglaman, bojanz, jsacksick: Drop Drupal 8.7 support,...
mglaman’s picture

Status: Needs review » Fixed

8.7 is now dropped.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.