Replace usages of AssertLegacyTrait::assertRaw, that is deprecated

Adding the "Deprecated assertions" tag to add this into the kanban board https://contribkanban.com/board/Deprecatedassertions

I have added the patch which only includes test case fixes in #2.
Needs Review

Previous patch has some issue, uploaded new patch

Tests passed, moving the ticket for review.

I can still see many instances of assertRaw in core.

Replace remaining of assertRaw() as addressed in #11.
also can't create interdiff as patch in #8 needs reroll. see below screenshot

Re the comment by @mohrerao in #11.
assertRaw() is not available in kernel tests. please see https://api.drupal.org/api/drupal/core%21tests%21Drupal%21KernelTests%21...
So i just reroll the patch in #9
Also i could not generate interdiff with #9 as written earlier

Hi, its strange why the patch is not applying...
@nitesh624, please see the snapshot

hi @shobhit_juyal its because there is some commit has been pushed on to dev after my patch completed run. so in this situation core committers only take appropriate action

Rerolled the patch #15

Patch no longer applies.

Needs review.

RTBC +1

Hi @shobhit_juyal, The latest patch has one coding standard issue, So I have fixed this here is the patch and the interdiff.

3139409-27.patch looks good. RTBC again

The patch does not apply.

Also we need to remove

      'AssertLegacyTrait::assertRaw() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->responseContains() instead. See https://www.drupal.org/node/3129738',
      'AssertLegacyTrait::assertNoRaw() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->responseNotContains() instead. See https://www.drupal.org/node/3129738',

From \Drupal\Tests\Listeners\DeprecationListenerTrait::getSkippedDeprecations()

Rerolled patch #27 and also done changes as mentioned in #29, please review.

Trying to fix failed test cases in #31.
Replaced assertnoraw() deprecated function.

Removing unrelated changes and fixing tests.

Adding fix for failed test in #36

Fixed PHPLint issue in patch #38.

The patch does not apply. Kindly review new patch.

Kindly review a new patch.

Rerolled as #41 failed to apply

Fixing test cases.

#3227060: Replace usages of AssertLegacyTrait::assertNoRaw, that is deprecated has landed.

The deprecation message suppression has been removed.
All usage of assertRaw() has been replaced.
For me it is RTBC.

Committed/pushed to 9.3.x, thanks!

We should backport this to 9.2.x (without the deprecation suppression removal), but it needs a re-roll/rebase there.

Please review it.

@xjm pointed out that this appears to have introduced a random test failure, see https://www.drupal.org/pift-ci-job/2144401 and others.

Rolling back for now.

Switching back to responseContains() means this is the same as the original code, so this should fix the random fail issue.

This probably means the element we're looking for is sometimes visible, sometimes not - worth a follow-up if there isn't one already, however not the fault of this issue at all.

Back to 9.2.x for the backport again.

Rerolled and force pushed the 9.2.x branch. Marking NR as there were a number of merge conflicts so would like a manual review to confirm.

FYI: this broke the https://www.drupal.org/project/ckeditor5 tests. It was frustrating to solve.

The solution?

Use ::responseContains() instead of ::pageTextContains().

That's not what the issue title is saying, but … nonetheless this issue broke that. #68 implies as much. We should be warning module maintainers about this change.

I suspect this is only a problem for ::pageTextContains() calls that were trying to assert the presence of strings in AJAX responses. Maybe that was not a technically correct usage of that assertion method, but it did work before. So chances are that more module maintainers are adversely affected by this.

Can we please add a change record to warn module maintainers? 🙏

Updated CKEditor 5 tests in #3227531: Unbreak tests: Drupal core's #3139409 broke tests.

@Wim Leers I am not sure how the conversions in this issue broke your tests. The change record at https://www.drupal.org/node/3129738 already says that assertRaw() should be converted to responseContains(). The deprecation notice on assertRaw() says the same thing:

    @trigger_error('AssertLegacyTrait::assertRaw() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->responseContains() instead. See https://www.drupal.org/node/3129738', E_USER_DEPRECATED);

The difference with this issue is that instead of doing a 1:1 conversion, assertRaw() was often the wrong assertion when a test was really looking for page text and not raw HTML, and so pageTextContains() was more appropriate.

However, are you saying that if you revert the MR from this issue, your tests pass? ie. that we have broken an assertion in this issue that contrib previously relied on?

However, are you saying that if you revert the MR from this issue, your tests pass? ie. that we have broken an assertion in this issue that contrib previously relied on?

Yes 🙈

Any update?

Bumping this as it is blocking backport of #3227501: [backport] Remove remaining uses of t() in test assertions

I don't think a change record is needed here, we already have https://www.drupal.org/node/3129738

Needs another rebase.

I think it's just this: core/modules/editor/tests/src/Functional/QuickEditIntegrationLoadingTest.php

I only merged 9.2.x into 3139409-9.2.x but no conflicts were triggered.
Not sure if it needed to be rebased... I'm moving the issue to NR to get more feedbacks.

Rebase was plenty. Committed/pushed to 9.2.x, thanks!