drupal-check web/modules/contrib/owlcarousel
 6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------------------------------
  Line   src/Plugin/Field/FieldFormatter/OwlCarouselFieldFormatter.php
 ------ ----------------------------------------------------------------------------------
  58    Call to deprecated method getStorage() of class Drupal\Core\Entity\EntityManager:  
         in drupal:8.0.0 and is removed from drupal:9.0.0.                               
         Use \Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() instead.
 ------ ----------------------------------------------------------------------------------


 [ERROR] Found 1 error
CommentFileSizeAuthor
#9 drupal9_deprecated_code-3139066-9.patch5.75 KBlilit_ghazaryan
#7 drupal9_deprecated_code-3139066-7.patch4.7 KBlilit_ghazaryan
#4 drupal_9_deprecated_method-3139066-4.patch1.02 KByonas.legesse

Comments

yonas.legesse created an issue. See original summary.

yonas.legesse’s picture

yonas.legesse commented
Issue summary: View changes
yonas.legesse’s picture

yonas.legesse commented
Parent issue: » #3087556: Drupal 9 Deprecated Code Report
yonas.legesse’s picture

yonas.legesse commented
StatusFileSize
new drupal_9_deprecated_method-3139066-4.patch1.02 KB

I've applied the patch provided in the parent issue. Another fix is made in regards to the issue at hand.

yonas.legesse’s picture

yonas.legesse commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: drupal_9_deprecated_method-3139066-4.patch, failed testing. View results

lilit_ghazaryan’s picture

lilit_ghazaryan commented
Status: Needs work » Needs review
Issue tags: +Drupal 9 porting weekend, +Epam-contrib-2020-05
StatusFileSize
new drupal9_deprecated_code-3139066-7.patch4.7 KB

vendor/bin/drupal-check web/modules/contrib/owl-carousel/
6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

vendor/bin/rector process web/modules/contrib/owl-carousel/

18/18 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] Rector is done!

Status: Needs review » Needs work

The last submitted patch, 7: drupal9_deprecated_code-3139066-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

lilit_ghazaryan’s picture

lilit_ghazaryan commented
StatusFileSize
new drupal9_deprecated_code-3139066-9.patch5.75 KB
lilit_ghazaryan’s picture

lilit_ghazaryan commented
Status: Needs work » Needs review
luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented

On #9 - I'm pretty sure that these hunks needs to be reverted:

@@ -21,7 +27,7 @@ function template_preprocess_owlcarousel_views(array &$vars) {
   $vars['attributes']['class'][] = 'owl-slider-wrapper';
   $vars['attributes']['class'][] = $vars['id'];
   $vars['attributes']['class'][] = 'owl-carousel';
-  $vars['#attached']['library'][] = 'owlcarousel/owlcarousel';
+  $vars['#attached']['library'][] = 'owl_carousel/owlcarousel';
   // Config set for owlcarousel.
   // This is then accessible in JS via drupalSettings.
   $vars['#attached']['drupalSettings']['owlcarousel_views'][$vars['id']] = JSON::encode($settings);

@@ -344,11 +356,12 @@ class OwlCarouselFieldFormatter extends EntityReferenceFormatterBase implements
       $s = $this->getSetting($k);
       $settings[$k] = isset($s) ? $s : $settings[$k];
     }
+
     return [
       '#theme' => 'owlcarousel',
       '#items' => $elements,
       '#settings' => $settings,
-      '#attached' => ['library' => ['owlcarousel/owlcarousel']],
+      '#attached' => ['library' => ['owl_carousel/owlcarousel']],
     ];
 
   }

The correct library name is 'owlcarousel/owlcarousel' here.

Was there a reason for switching up the constructor typehint here?

   /**
    * {@inheritdoc}
    */
-  public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, $label, $view_mode, array $third_party_settings, AccountInterface $current_user, Entit$
+  public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, $label, $view_mode, array $third_party_settings, AccountProxy $current_user, EntitySto$
     parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings, $label, $view_mode, $third_party_settings);
     $this->currentUser = $current_user;
     $this->imageStyleStorage = $image_style_storage;
luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Status: Needs review » Needs work

  • ipwa committed 4b2b9ff on 8.x-1.x authored by dakruchko 
    Issue #3139066 by Lilit_Ghazaryan, yonas.legesse, Luke.Leber: Drupal 9...

ipwa credited dakruchko.

ipwa’s picture

ipwa commented
Status: Needs work » Fixed

Committed patch from parent issue.

@Lilit_Ghazaryan please open a new ticket for the other changes in your patch.

Than you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.