Problem/Motivation

As the title says, when the content of the page is smaller than the viewport height, the definition for the footer region .page__footer .region { margin-bottom: -$block-spacer-y; } makes the page scroll vertically.

This was introduced in #3107048 - Improve footer layout.

Proposed resolution

Check why this negative margin definition is needed and fix it.

CommentFileSizeAuthor
#5 3137537-footer-margin-compensation-5.patch577 bytessasanikolic
#2 3137537-footer-margin-compensation.patch595 bytessasanikolic

Comments

sasanikolic created an issue. See original summary.

sasanikolic’s picture

sasanikolic commented
Status: Active » Needs review
StatusFileSize
new 3137537-footer-margin-compensation.patch595 bytes

Here is the proposed patch that fixes the margin compensation, that was added to the blocks/region.

Tested various cases, with footer content blocks and without. Worked fine for me.

pivica’s picture

pivica commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +next-release

Looks good, marking as reviewed for now and tagging for next release. Let's test this first a bit with real projects now :)

pivica’s picture

pivica commented
Status: Reviewed & tested by the community » Needs work

Actually sorry, this is a layout rule, so it should go to the top of the rules before background-color.

sasanikolic’s picture

sasanikolic commented
Status: Needs work » Needs review
StatusFileSize
new 3137537-footer-margin-compensation-5.patch577 bytes

Ops, my mistake. Fixed the order now.

pivica’s picture

pivica commented
Status: Needs review » Reviewed & tested by the community

Thx.

  • pivica committed 63eb387 on 8.x-1.x authored by sasanikolic 
    Issue #3137537 by sasanikolic, pivica: When page is vertically smaller...
pivica’s picture

pivica commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.