Problem/Motivation

There are couple of smaller layout problems in footer:
- If footer copyright region is missing (no blocks) we will get vertical empty space bellow footer region.
- To top block (coming from bs_lib) have height dimensions on big screens while it is hidden, because of bottom block margin.

CommentFileSizeAuthor
#4 improve-footer-layout-3107048-4.patch1.13 KBpivica
#4 interdiff-3099042-3-4.txt820 bytespivica
#3 improve-footer-layout-3107048-3.patch1.46 KBpivica
#3 interdiff-3107048-2-3.txt680 bytespivica
#2 improve-footer-layout-3107048-2.patch1.06 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
StatusFileSize
new improve-footer-layout-3107048-2.patch1.06 KB

Here is a patch.

pivica’s picture

pivica commented
Status: Active » Needs review
StatusFileSize
new interdiff-3107048-2-3.txt680 bytes
new improve-footer-layout-3107048-3.patch1.46 KB

Small improvement for small screens.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3099042-3-4.txt820 bytes
new improve-footer-layout-3107048-4.patch1.13 KB

Actually it is better to revert the previous change and also remove general footer block_title margin reset, because we have responsive reset later. Tests show this works better for various cases.

  • pivica committed a91b93d on 8.x-1.x 
    Issue #3107048 by pivica: Improve footer layout
pivica’s picture

pivica commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.