Add core_version_requirement: ^8 || ^9 to openstory.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

CommentFileSizeAuthor
#7 after_applying_patch.png15.17 KBankitsingh0188
#7 3137471-7.patch7.09 KBankitsingh0188
#4 3137471-4_errors_1.png55.46 KBankitsingh0188
#4 3137471-4_errors.png353.07 KBankitsingh0188
#2 3137471-2.patch365 bytesashutosh.mishra

Comments

ashutosh.mishra created an issue. See original summary.

ashutosh.mishra’s picture

ashutosh.mishra commented
StatusFileSize
new 3137471-2.patch365 bytes
ashutosh.mishra’s picture

ashutosh.mishra commented
Status: Needs work » Needs review
ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
Location Pune
commented
StatusFileSize
new 3137471-4_errors.png353.07 KB
new 3137471-4_errors_1.png55.46 KB

Hi Ashutosh,

After applying the patch, there are still a few errors that make this module incompatible with D9.
errors
erros

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
Location Pune
commented
Status: Needs review » Needs work
ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
Location Pune
commented
Assigned: Unassigned » ankitsingh0188
ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
Location Pune
commented
Assigned: ankitsingh0188 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3137471-7.patch7.09 KB
new after_applying_patch.png15.17 KB

Created the patch and makes it compatible with D9.
after applying patch

xld’s picture

xld commented
Assigned: Unassigned » xld

  • XLD committed 33d92e9 on 8.x-2.x authored by ankit.singh 
    Issue #3137471 by ankit.singh, ashutosh.mishra: Drupal 9 Readiness
xld’s picture

xld commented
Status: Needs review » Reviewed & tested by the community

Patch #7 looks good to me. Many thanks. Have committed it on another branch and will test so this can go to RTBC from my point of view.

  • XLD committed 33d92e9 on 8.x-3.x authored by ankit.singh 
    Issue #3137471 by ankit.singh, ashutosh.mishra: Drupal 9 Readiness
xld’s picture

xld commented
Status: Reviewed & tested by the community » Fixed
xld’s picture

xld commented
Status: Fixed » Closed (fixed)