Add core_version_requirement: ^8 || ^9 to popup_dialog.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

CommentFileSizeAuthor
#3 3137418-2.patch320 bytesmo_farhaz
#2 3137418-2.patch358 bytesmo_farhaz

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz commented
Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
StatusFileSize
new 3137418-2.patch358 bytes

please review.

mo_farhaz’s picture

mo_farhaz commented
StatusFileSize
new 3137418-2.patch320 bytes
pradeepjha’s picture

pradeepjha commented
Issue tags: +Drupal 9 compatibility
pradeepjha’s picture

pradeepjha commented
Assigned: Unassigned » pradeepjha

Hi @mo_farhaz, Please add comment for your respective patch properly. I guess #2 patch is for `8.x-2.x` versions and #3 patch is for `8.x-1.x` versions.

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Issue tags: +DIACWMay2020

  • imalabya committed 9ab527d on 8.x-2.x authored by mo_farhaz 
    Issue #3137418 by mo_farhaz, pradeepjha, imalabya: Drupal 9 readiness
imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs review » Reviewed & tested by the community

Applied the patch

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Reviewed & tested by the community » Fixed

Added to 8.x branch

pradeepjha’s picture

pradeepjha commented
Assigned: pradeepjha » Unassigned
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Drupal 9 porting weekend

Presuming this is for Drupal 9 porting weekend since patch was tested and committed during that time.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.