Postponed on #3023311: Modal dialog style update

Problem/Motivation

In #3023311: Modal dialog style update it was pointed out that the high contrast mode close button "icon" is not completely centered ("icon" in quotes as high contrast mode does not load CSS background images)

Proposed resolution

The "icon" is actually borders from ::before and ::after pseudoselectors. Potential solutions are

  • Finessing the styling so it is fully centered.
  • Find another approach to creating a high-contrast compatible icon that is easier to center
  • Change the hover/focus effect so the lack of centering is less apparent. High contrast mode is already a significantly different experience, so a change to hover/focus styling is probably acceptable.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 Screenshot 2024-04-29 at 9.57.56 AM.png50.71 KBgauravvvv
#12 3137015-nr-bot.txt150 bytesneeds-review-queue-bot
#10 3137015-10.png540.44 KBjavi-er

Issue fork drupal-3137015

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Postponed » Active

This is no longer postponed.

javi-er made their first commit to this issue’s fork.

javi-er opened merge request !2371

javi-er’s picture

javi-er commented
Assigned: Unassigned » javi-er
javi-er’s picture

javi-er commented
Assigned: javi-er » Unassigned
Status: Active » Needs review
StatusFileSize
new 3137015-10.png540.44 KB

I adjusted the close icon before and after position to better align it, see screenshot below:

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3137015-nr-bot.txt150 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Closed (outdated)
StatusFileSize
new Screenshot 2024-04-29 at 9.57.56 AM.png50.71 KB

This issue is no longer reproducible, as the approach for high contrast has been changed and the icon seems to be aligned perfectly with the new approach. Attached screenshot for reference.