Problem/Motivation

As a part of https://www.drupal.org/project/redirect/issues/2850121 we should fix the coding standard issues for:

If the line declaring an array spans longer than 80 characters, each element should be broken into its own line

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3136898-redirect-arrays-sniffs-3.patch14.44 KBandralex
#2 3136898-redirect-arrays-sniffs-2.patch29.51 KBandralex

Comments

andralex created an issue. See original summary.

andralex’s picture

andralex commented
Status: Active » Needs review
StatusFileSize
new 3136898-redirect-arrays-sniffs-2.patch29.51 KB

Here is a patch to fix code styles for array sniffs.

andralex’s picture

andralex commented
StatusFileSize
new 3136898-redirect-arrays-sniffs-3.patch14.44 KB

Fixed line endings in the patch file.

andralex’s picture

andralex commented
Version: 7.x-2.x-dev » 7.x-1.x-dev

Changed target version to 7.1 according to the parent issue. The last patch is still relevant and needs to be reviewed.

ysamoylenko’s picture

ysamoylenko commented
Status: Needs review » Reviewed & tested by the community

The #3 looks good for me.
Happy to RTBC!

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: Unassigned » kristen pol

Assigning to myself as I'm triaging all RTBC issues.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Reviewed & tested by the community » Needs work
Related issues: +#3136904: Line exceeds 80 characters

Thanks for the issue, patches, and review.

This should be combined with:

#3136904: Line exceeds 80 characters

so there is only one issue and patch.

Please review the guidelines for issue credit gaming here:

https://www.drupal.org/drupalorg/docs/marketplace/abuse-of-the-contribut...

In particular:

Bulk posting of low-effort issues, such as:
Conversion from README.txt to README.md or other minor readme fixes
phpcs (code style) fixes
etc.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » Unassigned

Unassigning for someone to combine these and keep one issue and close the other as duplicate.

wylbur’s picture

wylbur commented
Status: Needs work » Closed (outdated)

Closing this as Outdated as Drupal 7 is EOL.