Problem/Motivation

As a part of https://www.drupal.org/project/redirect/issues/2850121 we should fix the coding standard issues for:

Missing parameter type

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 phpcs-redirect-august-9-2023-3136895.txt46.65 KBkristen pol
#4 3136895-redirect-missing-parameter-type-4.patch16.89 KBandralex
#2 3136895-redirect-missing-parameter-type-2.patch16.29 KBandralex

Comments

andralex created an issue. See original summary.

andralex’s picture

andralex commented
Status: Active » Needs review
StatusFileSize
new 3136895-redirect-missing-parameter-type-2.patch16.29 KB

Fixed type hinting issues

Status: Needs review » Needs work

The last submitted patch, 2: 3136895-redirect-missing-parameter-type-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

andralex’s picture

andralex commented
Status: Needs work » Needs review
StatusFileSize
new 3136895-redirect-missing-parameter-type-4.patch16.89 KB

Fixed the first argument according to the allowed type inredirect_field_attach_form.

andralex’s picture

andralex commented
Version: 7.x-2.x-dev » 7.x-1.x-dev

Changed target version to 7.1 according to the parent issue. The last patch is still relevant and needs to be reviewed.

ysamoylenko’s picture

ysamoylenko commented
Status: Needs review » Reviewed & tested by the community

The #4 looks good for me.
Please commit the changes.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: Unassigned » kristen pol

Assigning to myself as I'm triaging all RTBC issues.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
StatusFileSize
new phpcs-redirect-august-9-2023-3136895.txt46.65 KB

Thanks for the issue, patches, and review.

Normally, all phpcs problems should be in one issue, see:

#2850121: Fix coding standards

But, given the extensive coding standard problems, then I'm okay with this one being separate since it has quite a few on its own.

Applied the patch and ran:

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

and didn't see any more Missing parameter type. See results.

I need to review the code with fresh eyes but this one might be okay to merge.

wylbur’s picture

wylbur commented
Status: Reviewed & tested by the community » Closed (outdated)

Closing this as Outdated as Drupal 7 is EOL.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » Unassigned

cleaning up my issues list