Remove deprecated FeedsAnnotationFactory class

I wonder though when it is a good time to remove it. It has only be deprecated since about half a year now. Maybe when Drupal 8.8 support stops? (Assuming Feeds won’t reach a stable D8 release this year - I’m planning to update the roadmap as right now I’ve only planned a few issues ahead)

Btw no usage in contrib found http://grep.xnddx.ru/search?text=FeedsAnnotationFactory

@andypost
What’s actually being deprecated is to use annotation for declaring dependencies on services in Feeds plugins:

 *   arguments = {
 *     "@file.usage",
 *     "@entity_type.manager",
 *     "@stream_wrapper_manager"
 *   },

See https://www.drupal.org/node/3097376

So I don’t expect any direct usage of the class itself in contrib code.

@jcnventura
Thanks for pointing me at that. This should be removed from \Drupal\Tests\feeds\Kernel\Feeds\Processor\EntityProcessorBaseTest:

'arguments' => [
  '@entity_type.manager',
  '@entity_type.bundle.info',
],

Deleted src/Plugin/Type/FeedsAnnotationFactory.php from the repo and removed

'arguments' => [
  '@entity_type.manager',
  '@entity_type.bundle.info',
],

From \Drupal\Tests\feeds\Kernel\Feeds\Processor\EntityProcessorBaseTest:
Please review the patch.

Setting this to "Postponed" as changing this now I think is too early.

Marking this issue as a stable release blocker.

Pull request created for all the changes.
The upgrade status is complaining about this deprecated class.

I did not remove it yet, because the implementation of Paragraphs has not yet been adjusted to work without the deprecated class:
https://git.drupalcode.org/project/paragraphs/-/blob/8.x-1.x/src/Feeds/T...

Should I remove it now and then create a new release, then people who have Paragraphs installed probably will get a fatal error on the mapping page.

Maybe you should create a new issue for the Paragraphs project to warn them about the removal.

I've updated the MR and I created an issue for Paragraphs: #3454863: Remove usage of deprecated FeedsAnnotationFactory.

Yes this has had a deprecation notice for some time. Time to let it go!

The FeedsAnnotationFactory has now been removed!