Issue :
ARIA role of aria-expanded is missing for the show more/show less option when used.

Fix: When show more link is specified add aria-expanded=false
and when show less exists on the page add aria-expanded=true

https://www.w3.org/TR/wai-aria-practices-1.1/examples/accordion/accordio...

CommentFileSizeAuthor
#5 facets-508-show-more-3136374-5.patch1.16 KBsmustgrave
#3 facets-508-show-more-3136374-2.patch1.08 KBsmustgrave
#2 facets-508-show-more-3136374-2.patch1.11 KBsmustgrave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave commented
FileSize
facets-508-show-more-3136374-2.patch1.11 KB
smustgrave’s picture

smustgrave CreditAttribution: smustgrave commented
FileSize
facets-508-show-more-3136374-2.patch1.08 KB
smustgrave’s picture

smustgrave CreditAttribution: smustgrave commented
Status: Active » Needs review
smustgrave’s picture

smustgrave CreditAttribution: smustgrave commented
FileSize
facets-508-show-more-3136374-5.patch1.16 KB

508 team identified a 2nd issue that this patch should resolve. Hoping this can be incorporated into the module.

Status: Needs review » Needs work

The last submitted patch, 5: facets-508-show-more-3136374-5.patch, failed testing. View results

smustgrave’s picture

smustgrave CreditAttribution: smustgrave commented
Status: Needs work » Needs review

Added the wrong test.

jannakha’s picture

jannakha CreditAttribution: jannakha as a volunteer and at Tomato Elephant Studio commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Issue tags: +Accessibility

This looks great and increases our accessiblity, thanks!

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at Jarltech Europe GmbH commented
Version: 8.x-1.4 » 8.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed after re-testing. Thanks for your help!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.