Make this project compatible for drupal 9.
suggestions:
- use drupal-check, rector , upgrade_status module to check the changes needed to be done
- Add version key for drupal 9 in info.yml file.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Screen Shot 2020-05-22 at 10.51.40 AM.png | 12.41 KB | ramya balasubramanian |
| #3 | drupal9-readiness-3136349-3.patch | 892 bytes | pradeepjha |
Issue fork nice_imagefield_widget-3136349
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
pradeepjha commentedComment #3
pradeepjha commentedComment #4
pradeepjha commentedComment #5
ramya balasubramanian commentedI have checked this and this patch looks good to me!! I have attached screenshots also. Moving this to RTBC
Comment #6
vaibhavjain@pradeepjha @Ramya Balasubramanian This an API change, mentioned here https://www.drupal.org/node/3084730 Can you please make sure that there is no Code change involved ? Also, is the module functioning well tested on D9 branch ?
Comment #7
pradeepjha commentedThanks @vaibhavjain. Your point is valid.
We have one similar ticket https://www.drupal.org/project/draggable_dashboard/issues/3128932, which is now in fixed state. There also the "core/jquery.ui.sortable" asset library is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. We have applied similar patch to fix it. Still someone can apply patch and test it the functionality. I think better we can move it to `in review` state.
Comment #8
vaibhavjainSure, @pradeepjha. We have done some similar implementation here (https://www.drupal.org/project/autocomplete_deluxe/issues/3122933), where jQuery sortable was replaced with core/sortable. If you plan to debug this further, you may want to refer to the above issue.
Comment #10
shevgenyThis Module does not work on Drupal 9 and needs to be improved. Images are not sorted.
Comment #11
sashken2 commentedI'm use https://www.drupal.org/project/jquery_ui_sortable and sortable in Nice ImageField Widget works.
Comment #15
terry_kolodiy commentedComment #16
terry_kolodiy commentedReleased D9-D10 version.