Problem

The Sky theme uses the <h2> tag for its hero block. However, it's the page title so a <h1> is more appropriate. In addition this is also what's used in the default Open Social flavour.

Solution

Change the Sky hero title tag to <h1> instead.

CommentFileSizeAuthor
#11 Screenshot from 2022-09-01 12-54-40.png94.7 KBanjali rathod
#7 3135863-7.patch2.63 KBSwapnil_Kotwal

Comments

Kingdutch created an issue. See original summary.

tdnshah’s picture

tdnshah commented
Assigned: Unassigned » tdnshah
raunak.singh’s picture

raunak.singh commented

Hi @tdnshah,
Please unsigned yourself if you are not working on this issue so others can pick this ticket
Thanks

tdnshah’s picture

tdnshah commented
Assigned: tdnshah » Unassigned
raunak.singh’s picture

raunak.singh commented
Assigned: Unassigned » raunak.singh
raunak.singh’s picture

raunak.singh commented
Assigned: raunak.singh » Unassigned
Issue tags: +Needs steps to reproduce

Hi @Kingdutch,
I am not able to reproduce this issue can you please add some screenshot or steps to reproduce this issue.
Thanks

Swapnil_Kotwal’s picture

Swapnil_Kotwal commented
StatusFileSize
new 3135863-7.patch2.63 KB
Swapnil_Kotwal’s picture

Swapnil_Kotwal commented

Issue was not able to reproduce at my end...but still made changes...dont know will that work... Kindly review

Swapnil_Kotwal’s picture

Swapnil_Kotwal commented
Status: Active » Needs review
kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Project: Open Social » Social Blue
Version: 8.x-9.x-dev » 1.1.x-dev
Component: Front-End » Code
anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
StatusFileSize
new Screenshot from 2022-09-01 12-54-40.png94.7 KB

I think it is an issue for the base theme, the title for hero block in the twig file uses
tag but the class given to it is h2 .
@Kingdutch please provide more context and screenshots of your issue.

roberttabigue’s picture

roberttabigue commented
Status: Needs review » Needs work

Hi @Kingdutch,

Moving this to "Needs work" and please provide more context and screenshots of your issue, please.

Thank you.

agamich’s picture

agamich commented
Status: Needs work » Closed (outdated)

Hey everyone, currently HTML tag for the title on the hero banners was changed to H1.
You can see a couple of theme MRs:
https://git.drupalcode.org/project/socialblue/-/commit/acc92bda94da32b94...
https://git.drupalcode.org/project/socialblue/-/commit/ba9b86f657c3937f3...