Drupal 9 readiness meeting / 11 May 2020 [#3135577]

Meeting will happen in #d9readiness on drupal.slack.com.

Hello and welcome to this Drupal 9 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 9 upgrade of their sites are also welcome.
➤ Usually happens every Monday at 18:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3135577`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

kristen_pol	:wave: Kristen, Coarsegold, California, USA
nerdstein	:wave: nerdy, pennsylvania, USA
dan2k3k4	:wave: Dan, Zurich
tedbow	Ted from Ithaca, NY, USA
surabhi.gokte	Surabhi from India
longwave	Dave, UK
shaal	Ofer Shaal, Florida :sunglasses:
ccjjmartin	Chris Martin, Austin, TX, USA
dharizza	Hi, Dharizza, Costa Rica :slightly_smiling_face:
dww	Derek, usually Oakland, CA, now Hawi, HI
hestenet (he/him)	Tim - Portland, OR - with the DA.
pingwin4eg	Mike, Ukraine. :wave:
Gábor Hojtsy (he/him)	Gábor from Hungary
vuil	Ilcho, Bulgaria :flag-bg: :flag-eu:
JayKandari	:wave: Jaideep, Dehradun, India
greg.1.anderson	Greg, SF CA
jorgik	Yuriy UA
mikelutz	Hello!
diqidoq	Missed it? Still here? Sorry, late (Meeting) Hello everyone!

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

nerdstein	were new deprecations introduced by the upgrade of specific dependencies?
kristen_pol	Status update of @tedbow's automation of info yml patches with @shaal's rector fixes of the info yml file
surabhi.gokte	Any learnings from the last month's D9 Porting Day which can be taken care of this month!
ccjjmartin	Automated Semantic Versioning and current drupal.org setup
vuil	COVID issues related to Drupal community, especially Drupal 9, and DrupalCon updates? (edited)
vuil	Are there some specific stoppers / blockers as issues related to the new Drupal 9 stable release?
Gábor Hojtsy (he/him)	@vuil the blocker thread is https://drupal.slack.com/archives/CDDD98AMN/p1589220130379700 (already)

2️⃣ Drupal 9 RC week this week (also 8.9 RC and 8.8.6 release)

Gábor Hojtsy (he/him)	The window was extended from last week https://groups.drupal.org/node/535921
Gábor Hojtsy (he/him)	#3110198: [META] Beta targets following Drupal 9.0.0-beta1 and 8.9.0-beta1 has the remaining issues listed
greg.1.anderson	There was some talk about maybe delaying RC1 further to work out the problems with Composer wanting to ignore the prefer-stable setting in some instances & update sites to dev releases instead of stable.
greg.1.anderson	@xjm @alexpott ^^
Gábor Hojtsy (he/him)	hm, further? on Friday there will only be 19 days left until June 3
alexpott	I think the prefer-stable stuff mostly affect Drupal 8 at this point
greg.1.anderson	Is the rc1 of 8.9.0 going to be later than the rc1 of 9.0.0?
greg.1.anderson	Or are we going to keep composer/installers pinned to 1.7.0 in 8.9.0-rc1 (no delay in release)?
xjm	@Gábor Hojtsy (he/him) The situation is that if we commit the composer/installers change, it causes all the Drupal 8 composer sites to be given 8.9.x dependency composer updates, including to 8.9.x-dev, even from a stable release like 8.8.5. This change was originally supposed to be done before RC, so we have to disentangle how to solve that. (This is on top of the other couple criticals.) (edited)
xjm	Because while delaying the RC even more isn't good, neither is having to make 8.8.7 and RC2 a few days after 8.8.6 and RC1
Gábor Hojtsy (he/him)	So?
xjm	To clarify: I'm not making 8.8.6, 8.9.0-rc1, and 9.0.0-rc1 on Wednesday if I'm just going to have to make 8.8.7, 8.9.0-rc2, and 9.0.0-rc2 on Friday.
xjm	So as I said, it still needs to be sorted.
Gábor Hojtsy (he/him)	Ok I thought that was a comment on delaying the RC further (than the window this week).
xjm	Yes, Greg asked if we would, and the answer is I don't know yet. It depends on what happens with all these issues.
xjm	I also don't want ot make a bunch of releases on Friday if I'm only going to have to make a bunch more next Wednesday.
xjm	It pisses people off when we do that
Gábor Hojtsy (he/him)	That’s great info thanks!
Gábor Hojtsy (he/him)	Looks like helping @greg.1.anderson el. al untangle / test with / provide feedback on #3134648: [backport, needs scheduling] Don't pin the composer/installers version in drupal/core-recommended would be useful from attendees of this meeting.
alexpott	Feedback on #3135247: Composer's "prefer-stable" setting cannot be relied on to produce a stable release would be great too

3️⃣ Any new deprecated APIs introduced by dependency updates

Gábor Hojtsy (he/him)	@nerdstein raised this
Gábor Hojtsy (he/him)	I don’t think there should be any new that must be fixed
nerdstein	notably, we saw a potential around the Diaspora messaging tied to PSR
Gábor Hojtsy (he/him)	that said, there may be stuff that does not need to be fixed, eg. Symfony 4 to 5 deprecations
nerdstein	got it --- so if projects are using direct Symfony packages, there may be some work to resolve things?
longwave	things deprecated in Symfony 4.x have an open meta with a number of child issues being worked on: #3055180: [META] Symfony 5 compatibility
Gábor Hojtsy (he/him)	I don’t know of specific things raised with the most recent dependency updates but that is the kind of stuff to look for yeah

4️⃣ Updates from Upgrade Status and drupal-check

Gábor Hojtsy (he/him)	Made a massive new Upgrade Status release last week :slightly_smiling_face:
Gábor Hojtsy (he/him)	https://twitter.com/gaborhojtsy/status/1258785969517613057
Gábor Hojtsy (he/him)	also made a big update to the project page, and put up a comparison table with drupal-check: https://twitter.com/gaborhojtsy/status/1259884938595315713
Gábor Hojtsy (he/him)	note that @mglaman is looking to sunset drupal-check: https://github.com/mglaman/drupal-check/issues/172
JayKandari	Drupal-Check has been an excellent tool.Extremely grateful to @mglaman for building it in the first place and helping Drupal :hearts:
Gábor Hojtsy (he/him)	Absolutely
mglaman	Thanks!
mglaman	I had a idea Maybe drupal-check isn’t completely deprecated, but it really shouldn’t be considered a standalone CLI. It could be used to generate PHPStan configuration and then folks just run ./vendor/bin/phpstan
mglaman	So ./vendor/bin/drupal-check can generate your Drupal PHPStan config for you? maybe? Trying to see what Larastan does

5️⃣ Updates from drupal-rector

Gábor Hojtsy (he/him)	there was a https://github.com/palantirnet/drupal-rector/releases/tag/0.5.2 release 2 days ago by @shaal that adds rectors fordb_update()file_scan_directory()REQUEST_TIMEentity_get_displayentity_get_form_displayfile_default_scheme()EntityInterface:urlInfo()(edited)
Gábor Hojtsy (he/him)	keep your local versions up to date every week to get the latest and greatest :slightly_smiling_face:
Gábor Hojtsy (he/him)	@kristen_pol raised this btw :)
nerdstein	i believe i raised it last week, but i did publish the rector blog post - http://nerdstein.net/blog/getting-started-drupal-rector-development
kristen_pol	Very excited to hear about any possible progress on the info file automation :slightly_smiling_face:
shaal	Still working on it. @tedbow had some concern with fixing this for projects that have other deprecations unresolved.
kristen_pol	Thanks for the update! Makes sense
kristen_pol	Definitely good to keep in mind. I've run into that issue where there are other issues open and then one just for the info file and then things have to be closed out and merged. It's probably fairly common.
shaal	Perhaps a solution would be a separate patch just for that file.
tedbow	@kristen_pol I was little concerned that if the bot that was providing changed the info.yml files it might be interpreted as we “know” it is compatible. But I think we good warning about needing to test it themselves on D9 it will be ok.
kristen_pol	Yeah, I think some caveats in the issue summary are fine if they are front and center (edited)
Gábor Hojtsy (he/him)	The patch needs testing either way
tedbow	yep

6️⃣ Updates on running drupal-rector on all drupal.org projects

Gábor Hojtsy (he/him)	@tedbow is working on this :slightly_smiling_face:
hestenet (he/him)	Speaking of which - I left comments and suggested edits on the blog, Ted. It's looking great.
tedbow	@hestenet (he/him) Great.@kristen_pol Yep so basically working on communication so this doesn’t hit people out of the blue
Gábor Hojtsy (he/him)	@kristen_pol raised this btw :)
hestenet (he/him)	When you think the post is done, Ted, I'll schedule for publication and prepare a corresponding email to send to project maintainers.
tedbow	@hestenet (he/him) sounds good!
kristen_pol	Whoops... I've been discussing this in the other thread :slightly_smiling_face:
hestenet (he/him)	@drumm Do you think it's better to have a separate project entirely for the bot's issue queue, or to use a new 'component' on Drupal infra? I could see either way.
drumm	I nearly always favor less projects.
tedbow	ok so a component under infra ?
hestenet (he/him)	I can add that component
tedbow	thanks!
hestenet (he/him)	Okay component "Bot: Drupal Rector" now exists - (figured there may be more bots eventually)
tedbow	Thanks. Updating the blog post
hestenet (he/him)	I can go ahead and get that staged up - looks like there's just one more comment about finding a 'better example issue'

7️⃣ Semantic versioning on drupal.org

Gábor Hojtsy (he/him)	@ccjjmartin raised “Automated semantic versioning” which I don’t know how to interpret, so made the topic a bit more general :slightly_smiling_face:
ccjjmartin	Yeah, I need to add more details
Gábor Hojtsy (he/him)	Please do here :slightly_smiling_face:
ccjjmartin	I am looking at adding integration with the node package semantic-release: https://github.com/semantic-release/semantic-releaseAnd am running into a few things:It might require a master branch but my current understanding is that we should not push a master branch up to drupal.org, I am going to see if I can get this to work without master but was hoping to verify if it is correct that we either can't or shouldn't push master to drupal.org.Do we have the ability to add gitlab releases on the current drupal.org repository setup? There are packages that integrate with GitLab but if module maintainers don't have access to that then, that is nothing for me to look into.
ccjjmartin	I am having a few other setup issues but I don't think it is directly related to how this will work at a community wide scale.
dww	#3125239: Suggest 1.0.x as the first branch to create instead of 1.x is the known bug about 2.x vs 2.0.x branches on d.o
dww	That said, not sure why anything cares about a master branch. Can you explain what that has to do with semver?
ccjjmartin	I am going to look into that issue later today but I named a branch 2.0.x (which I believe is the Drupal community recommendation?) and the package doesn't seem to want to create a tag on that branch. I am going to meet with someone who is familiar with the project and hopefully we can get that resolved.
dww	I don’t know your answer about gitlab releases. That seems like maybe a big can of worms. But potentially nothing stops you from having parallel release objects in different worlds. Eg d.o release nodes for all that brings, then a parallel “release” on the gitlab side for whatever functionality that unlocks. The two wouldn’t talk to each other, but in principle nothing stops you. (edited)
ccjjmartin	I think what it wants is a stable release, I am trying to make a 2.0.x branch as a prerelease branch so it could be related to that.
ccjjmartin	Module maintainers don't have any permissions to do anything on GitLab right? I haven't looked into it too deeply though.
dww	Guess I need to look into that node package. Maybe stepping back a sec: what is it providing that you want / need?
ccjjmartin	It will automatically update the changelog.txt for me based on commit messages. It will automatically version bump (the right semantic version) based on commit messages. Deploy tags to appropriate repositories. A lot of great things.Speaking of, I will need to alter commit messages to be formatted like:fix(some-bug): Issue #1234 by ccjjmartin: descriptionWill this break anything with issue credit?
dww	Brief skim of the github page:- determine next release #: seems to either be so trivial that who cares, or it’s incredibly complicated and potentially fragile. The maintainer needs to decide the semantics of the release to determine the appropriate next version
dww	Automatic release notes — there’s a drush command for that git_release_notes (edited)
ccjjmartin	Yeah, the maintainer would be the one to commit with the new messages.
dww	“Automatically publish the package” - that’s not going to work with d.o
dww	Not sure this is really necessary or all that helpful for Drupal extensions. ¯\_(ツ)_/¯
dww	Re: commit message format. I honestly don’t know the full extent of what the “credit bot” is doing these days, but you can always twiddle the credit checkboxes on the issues of it gets something wrong.
dww	But again, the d.o issue gives maintainers the commit message to copy / paste. That’s not going to match the format this tool wants. So you’re trading one set of automated tools for another.
dww	Are you familiar with https://www.drupal.org/project/grn ? Maybe that’s the tool you need to fold into your workflow to get most of the benefit you’re seeking?
pingwin4eg	AFAIK, a commit message has nothing to do with issue credits. But that's a non-standard commit message, and it might break d.o. auto tools, e.g. issue linking, contributors parsing, etc.
drumm	Really all we do with commit messages is parse for #1234 and see if the number is an issue within the same project and do a couple other checks to see if a commit comment would be relevant. The rest is community conventions.
drumm	@ccjjmartin switching to GitLab’s release packages instead of Drupal.org’s would be quite a big task. For example, GitLab would not publish update status XML that we rely on to help people know if they are running outdated or insecure releases. And integration with our Composer/Packagist endpoint. We do not allow release to be created on GitLab directly in the meantime, it would be very confusing for end users to have two completely different ways to install Drupal modules.
drumm	#2940427: Keep track of commits in a release is open too, would be nice to have the commits in a release just be there, with no tools to add on
drumm	(#2270763: Automatically fix issues when commit message contains "Fixed …" keyword (powerful/smart commit messages) might be interesting too.)
ccjjmartin	Thanks all, this is still in the testing phase for me to see if this is a viable solution. I will look into the various resources that have been linked here as homework. Appreciate the help.

8️⃣ Drupal 9 Porting Weekend May 22-23, 2020

Gábor Hojtsy (he/him)	Thanks for @surabhi.gokte and @gambry for not letting me sit on my laurels on this :slightly_smiling_face:
Gábor Hojtsy (he/him)	we are organizing a porting weekend for end of next week https://groups.drupal.org/node/535917
surabhi.gokte	If interested in mentoring in your timezone, let us know! :slightly_smiling_face: (edited)
Gábor Hojtsy (he/him)	4-5 folks reached out to me so far, we need a lot more to lead :)
Gábor Hojtsy (he/him)	(I should also add those 4-5 people now :D)
Gábor Hojtsy (he/him)	@surabhi.gokte raised the topic of what we learned from porting day in April
Gábor Hojtsy (he/him)	I think we’ll need more of a framework that helps contributors to make contributions the best way
Gábor Hojtsy (he/him)	I am not sure I have time to build that by next weekend, but @kristen_pol did a great job dropping her train of thought into a blog post, so that would be good start for a writeup :slightly_smiling_face:
nerdstein	can we help promote this?
surabhi.gokte	sure, why not!
nerdstein	cool - any ideas?
surabhi.gokte	maybe in the weekly newsletters of respective agencies..
surabhi.gokte	just thinking out loud
Gábor Hojtsy (he/him)	@nerdstein yeah whatever channels you have access to :slightly_smiling_face: it was top news in last week’s Weekly Drop / Drupal Newsletter: http://www.theweeklydrop.com/archive/issue-436
Gábor Hojtsy (he/him)	its pinned to groups.drupal.org’s frontpage, but I don’t know who ever goes there anymore other than through RSS readers
surabhi.gokte	yeah!
Gábor Hojtsy (he/him)	but this is the canonical event URL https://groups.drupal.org/node/535917
surabhi.gokte	and its 2 days this time - Friday and Saturday
nerdstein	are you seeking volunteers again @Gábor Hojtsy (he/him)?
kristen_pol	I was thinking about a blog post of some sorts like "Getting ready for Drupal 9 porting weekend"... i.e. how people could get themselves set up to hit the ground running... thoughts?
surabhi.gokte	that's a great idea, @kristen_pol (edited)
Gábor Hojtsy (he/him)	@kristen_pol that would be amazing
kristen_pol	Cool, I'll see what I can do.To be honest, it's embarrassing to publish stuff on my site as it's still on D6 o_O but I don't have enough time to update my site when I'm doing a gazillion patch reviews :stuck_out_tongue:
Gábor Hojtsy (he/him)	@nerdstein yes looking for volunteers as indicated in the g.d.o post
nerdstein	ok
mikelutz	I can do a few hours on Friday in US TZ again.
Gábor Hojtsy (he/him)	@mikelutz I’d love to put people up with date/times if possible :slightly_smiling_face:
kristen_pol	I can do both Friday and Saturday (Pacific time). I'll probably be helping much of the day but to get my "official" times, I'll need to check with my husband to make sure he's on "watching mom duty". Probably official times will be in the afternoon. (edited)
Gábor Hojtsy (he/him)	@kristen_pol great, please let me know when you have them :slightly_smiling_face:
Gábor Hojtsy (he/him)	So far @vaibhavjain signed up with enough info for me to put up,@tsega and @Mukesh Agarwal and @JayKandari also reached out to me but I am in the process of figuring out their planned hours :slightly_smiling_face:
Gábor Hojtsy (he/him)	More coverage around Europe’s timezones and US timezones would definitely be needed as I don’t have anyone written up for those :slightly_smiling_face:
surabhi.gokte	woah, we have 3 from IST :smile:
nerdstein	@mikelutz - do you want to do like noon to 3pm eastern on friday (if i recall, thats the time we did last time)
mikelutz	@nerdstein Yeah, that sounds good.
Gábor Hojtsy (he/him)	ok added both of you to https://groups.drupal.org/node/535917
kristen_pol	@Gábor Hojtsy (he/him) Just checked with my husband and he's flexible but let's do my official hours from noon to 5pm Pacific both days. Likely I'll be able to help in the morning and evening as well.
Gábor Hojtsy (he/him)	@kristen_pol done, added, thanks so much
kristen_pol	Woot!
gambry	@Gábor Hojtsy (he/him) I can be available 08-16 UTC+1 on Friday and 8-12 on Saturday. Ideal for west europe coverage.
Gábor Hojtsy (he/him)	@gambry you are in BST timezone right?
Gábor Hojtsy (he/him)	added you as well
Gábor Hojtsy (he/him)	@larowlan, @VladimirAus when/if you are on, are you interested to be leads on next weekend’s Drupal 9 porting weekend (again)? See https://groups.drupal.org/node/535917 for who signed up to lead already
larowlan	I can’t sorry, already have plans
tsega	@surabhi.gokte :wave::skin-tone-5: I'm actually EAT :simple_smile:
surabhi.gokte	Hey @tsega, I know.. why do you say?
tsega	woah, we have 3 from IST :smile: Thought I was one of the three … just saw that there were actually 4 mentions there :smile:
surabhi.gokte	:smile:
VladimirAus	@Gábor Hojtsy (he/him) i will be away Saturday but confirming if I can do Friday. Will let you know this Friday.
Gábor Hojtsy (he/him)	superb, thanks

9️⃣ 23 days until June 3, how do you plan to celebrate? (edited)

xjm	Sit alone in my apartment like everyone else? :stuck_out_tongue:
Gábor Hojtsy (he/him)	@dan2k3k4 is hard at work on a celebrations site similar to http://celebratedrupal8.com/ so we can all sit alone together
Gábor Hojtsy (he/him)	help is welcome at #d9launch
nerdstein	:beers:
diqidoq	I have a funeral on this day of a good friend who is a victim of COVID-19 ... but it is kind of ironic in this context because he brought me to Drupal 10 years ago. :cry:
diqidoq	But to answer the question positively: He was an awesome base player and since we both used to work together for long time back in the early 2000's touring Europe I will play him a song with new written lyrics about the Drupal 9 release. He would love it!
xjm	Oh, sorry to hear that @diqidoq!
Gábor Hojtsy (he/him)	@diqidoq so sorry to hear that :disappointed: