Is there an option to send an email in the event a backup fails? I see it in 7.x-3.x, but not in 8.x-4.x.
I see some code for it, such as class Mailer implements MailerInterface, but I don't see anything using that code, nor the option in the Settings Profiles page.
| Comment | File | Size | Author |
|---|---|---|---|
| #30 | backup_migrate-n3133933-30.patch | 6.53 KB | damienmckenna |
| #30 | backup_migrate-n3133933-30.interdiff.txt | 4.05 KB | damienmckenna |
| #29 | backup_migrate-n3133933-29.patch | 5.07 KB | damienmckenna |
| #14 | 3133933-10.patch | 4.62 KB | ramonvasconcelos |
| #9 | 3133933-9.patch | 3.87 KB | mrinalini9 |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
damienmckennaLet's make this a feature request, because I don't think it's possible either.
Comment #3
damienmckennaMoving 8.x-4.x issues to 5.0.x because the older branch is no longer supported.
Comment #4
larisse commentedHi! I tried to work on this feature, here is a patch. I think that is necessary create tests if this feature be committed.
Comment #6
larisse commentedA new patch.
Comment #7
paulocsFixing patch to add a properly key to the email.
Comment #8
damienmckenna#3236380 was committed, so this needs a reroll.
Comment #9
mrinalini9 commentedRerolled patch #7 for the 5.1.x branch, please review it.
Comment #10
ramonvasconcelos commentedI'll review the patch.
Comment #11
WagnerMelo commentedHi, i'll review it.
Comment #12
WagnerMelo commentedsorry.
Comment #13
ramonvasconcelos commentedThe reroll didn't work for me. It doesn't have all the changes made in the previous patchs.
I'll make some more tests and see if i can fix it.
Comment #14
ramonvasconcelos commentedI did another rebase for the #7 patch.
Please, review it.
Comment #15
ramonvasconcelos commentedComment #16
alexanderj commentedI will review this.
Comment #17
alexanderj commentedI reviewed the patch and everything was fixed and working correctly.
Moving it to RTBC.
Comment #18
damienmckennaThanks for the reroll and review. However, this removes the option to send an email on success, so needs a little further work so that both options are available.
Comment #19
ramonvasconcelos commentedOkay, i can take a look again.
Comment #23
ramonvasconcelos commentedI added the Success Email option again.
I suppose everything proposed by the issue is done. Please, review it.
When testing i realized something else tho. The default value for the Email Address for Success Notices and Email Address for Failure Notices fields is the Drupal System Site Email but when i change it to something different and save the value doesn't change after reloading the page. After more tests i saw that the correct value is being saved at the database, but is not being recovered to the frontend. Do you guys think we should correct this on this issue or open another one?
Comment #24
alexanderj commentedI will review again.
Comment #25
alexanderj commentedI reviewed the changes related to what was proposed in the issue and it's ok for me.
Regarding your second question, I don't know if this approach should be done here or in another task, I believe that the opinion of another members of the community is necessary.
Comment #26
pflora commentedI find the problem brought up by #23 to be out of the scope of this issue. Since #25 reviewd the changes and it seems to be working as intended, i'm moving it to RTBC.
Comment #27
solideogloria commentedIf this gets committed, make sure to review #23 and open a new issue if needed.
Comment #28
damienmckennahook_update() needs to be fixed, it still only supports $key=="backup_failed" and doesn't support the "backup_success" option.
Comment #29
damienmckennaI missed that the MR resolved some problems from the patch. So here's the MR in patch format.
Comment #30
damienmckennaSome streamlining of the method names.
Comment #32
damienmckennaCommitted. Any improvements can be done in separate issues. Thanks everyone!