Closed (fixed)
Project:
The Better Mega Menu
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Apr 2020 at 10:03 UTC
Updated:
29 Jan 2021 at 18:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
suresh prabhu parkala commentedPlease review.
Comment #3
quondam commentedThe patch provided in #2 no longer applies cleanly to the 8.x-1.x-dev branch and needs to be re-rolled.
Comment #4
quondam commentedThe previous patch didn't apply mainly because most of the logic from the
tb-megamenu-touch.jsfile has been rolled intotb-megamenu-frontend.js. I've re-rolled the proposed changes so the new patch applies to the 8.x-1.x-dev branch while also making further adjustments to better conform to coding standards. While technically more of a best practice than a standard I've also converted theTBMegaMenuBuilderclass into a service to allow the overall module to better leverage dependency injection, and eliminated calls to\Drupal::wherever possible.Comment #5
quondam commentedI'm planning to re-roll the patch from #4 since we're aiming to resolve 2965871 - and potentially some of the other open Major bugs - first. Additionally, after consulting with some of the project maintainers it seemed safer to address the new service and move towards dependency injection in a separate task, which I've created here.
Comment #6
andrewozoneWe are aiming for a stable release, so we are updating the priority to "Major".
Comment #7
knaffles commentedComment #8
quondam commentedOnce 3183288 has been fixed the patch from #5 should be re-rolled.
Comment #9
quondam commentedComment #10
quondam commentedI've re-rolled the patch from #5 again, ensuring it applies cleanly to the 8.x-1.x-dev branch following the completion of 3183288. When applying the patch please be sure it's against 8.x-1.x-dev, otherwise it'll fail. All functionality should be regression tested since a good portion of the module's codebase was updated to meet coding standards.
Comment #12
themodularlabIssue has been reviewed and tested by @knaffles and myself. Everything looks good. No regression issues found.
Comment #13
themodularlabIssue has been merged into the 8.x-1.x-dev branch. It will be a part of the next release.
Comment #15
themodularlabComment #16
themodularlab