Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    Comments

    suresh prabhu parkala’s picture

    Status: Active » Needs review
    StatusFileSize
    new36.99 KB

    Please review.

    quondam’s picture

    Assigned: Unassigned » quondam
    Status: Needs review » Needs work

    The patch provided in #2 no longer applies cleanly to the 8.x-1.x-dev branch and needs to be re-rolled.

    quondam’s picture

    Assigned: quondam » Unassigned
    Status: Needs work » Needs review
    StatusFileSize
    new68 KB

    The previous patch didn't apply mainly because most of the logic from the tb-megamenu-touch.js file has been rolled into tb-megamenu-frontend.js. I've re-rolled the proposed changes so the new patch applies to the 8.x-1.x-dev branch while also making further adjustments to better conform to coding standards. While technically more of a best practice than a standard I've also converted the TBMegaMenuBuilder class into a service to allow the overall module to better leverage dependency injection, and eliminated calls to \Drupal:: wherever possible.

    quondam’s picture

    Assigned: Unassigned » quondam
    Status: Needs review » Needs work
    Related issues: +#3183288: Replace calls to \Drupal with Dependency Injection

    I'm planning to re-roll the patch from #4 since we're aiming to resolve 2965871 - and potentially some of the other open Major bugs - first. Additionally, after consulting with some of the project maintainers it seemed safer to address the new service and move towards dependency injection in a separate task, which I've created here.

    andrewozone’s picture

    Priority: Normal » Major

    We are aiming for a stable release, so we are updating the priority to "Major".

    knaffles’s picture

    quondam’s picture

    Assigned: quondam » Unassigned

    Once 3183288 has been fixed the patch from #5 should be re-rolled.

    quondam’s picture

    Assigned: Unassigned » quondam
    quondam’s picture

    Assigned: quondam » Unassigned
    Status: Needs work » Needs review
    StatusFileSize
    new48.83 KB

    I've re-rolled the patch from #5 again, ensuring it applies cleanly to the 8.x-1.x-dev branch following the completion of 3183288. When applying the patch please be sure it's against 8.x-1.x-dev, otherwise it'll fail. All functionality should be regression tested since a good portion of the module's codebase was updated to meet coding standards.

    • themodularlab committed e8de55f on issue/3131180-drupal-coding-standards authored by quondam
      Issue #3131180 by quondam, Suresh Prabhu Parkala: Drupal coding...
    themodularlab’s picture

    Status: Needs review » Reviewed & tested by the community

    Issue has been reviewed and tested by @knaffles and myself. Everything looks good. No regression issues found.

    themodularlab’s picture

    Status: Reviewed & tested by the community » Fixed

    Issue has been merged into the 8.x-1.x-dev branch. It will be a part of the next release.

    themodularlab’s picture

    Status: Fixed » Closed (fixed)
    themodularlab’s picture