We currently have layout--content-narrow and layout--content-medium CSS classes that enable containers to stretch to a certain number of grid columns.

This task is to create two additional utility classes:

  • layout--content-wide
  • layout--content-full

Issue fork drupal-3130740

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

DuneBL created an issue. See original summary.

dunebl’s picture

StatusFileSize
new2.97 KB

Here is the patch

komalk’s picture

Version: » 8.x-1.0-alpha1
Assigned: Unassigned » komalk
komalk’s picture

Assigned: komalk » Unassigned

@DuneBL What is requirement of

layout--bigger-2 class

it just provide the extra column from left and right side.

dunebl’s picture

@komalkolekar : This is to provide an helper class as it is explained in the documentation here: https://paper.dropbox.com/doc/Olivero-vertical-spacing-grid--A0Nqav3A6SW...

mherchel’s picture

Title: Add helper classes to have a layout larger than the parent layout » Olivero: Add helper classes to have a layout larger than the parent layout
Project: Olivero » Drupal core
Version: 8.x-1.0-alpha1 » 9.1.x-dev
Component: Code » Olivero theme
mherchel’s picture

Issue summary: View changes
Issue tags: +CSS
mherchel’s picture

Issue summary: View changes
gauravvvv’s picture

I tried patch #2,
gauravmahlawat@Gauravs-Air olivero % git apply -v 0001-Add-bigger-layout-helper-class.patch
Skipped patch 'css/dist/layout/layout-bigger.css'.
Skipped patch 'css/src/layout/layout-bigger.css'.
Skipped patch 'olivero.libraries.yml'.

The patch didn't apply correctly.

mherchel’s picture

Version: 9.1.x-dev » 9.2.x-dev
Status: Active » Needs review
StatusFileSize
new10.8 KB

Some work on this.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

gauravvvv’s picture

Version: 9.3.x-dev » 10.0.x-dev
StatusFileSize
new84.78 KB
new116.68 KB

layout--content-wide Increases the width of the column, but not overlapping the sidebar region and layout builder dialog box.

gauravvvv’s picture

Version: 10.0.x-dev » 9.2.x-dev

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

sakthivel m’s picture

StatusFileSize
new7.9 KB

Just Re-roll the patch 9.3.x

Madhu kumar’s picture

Patch #15 applied cleanly and width of the column increased, Sharing screenshot for the reference.

chetanbharambe’s picture

Status: Needs review » Needs work
StatusFileSize
new445.52 KB
new616.74 KB

Verified and tested patch #15.
Patch applied successfully but not working as expected.

Testing Steps:
# Goto: Appearance -> Apply Olivero theme
# Goto: Extend ->install layout builder
# Goto: admin/structure/types/manage/article/display
# Give the permission under the layout option and save it
# Create a content type
# Save it
# Goto: layout and inspect the element and check respective classes.

Expected Results:
# User should see below mentioned two classes after applying the patch #15
layout--content-wide
layout--content-full
Both above classes are not appearing.

Actual Results:
# Currently user is able to see only layout--content-medium class

Please refer attached screenshots for the same
Not working as expected.
Can be a move to Needs Work.

vikashsoni’s picture

StatusFileSize
new96.46 KB
new180.84 KB
new142 KB

I have applied patch #15 applied successfully
But I can't see any changes Before patch and after patch the condition are same

For ref sharing screenshot .....

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

sime’s picture

StatusFileSize
new12.03 KB

I've updated this patch to apply to the latest core. I can see the class is being used, but the layout is not using more grid than the medium, and I'm not good enough at frontend to debug this.

sime’s picture

OK correction, it appears to be working. It still starts at column 3 but extends further to the right. I think potentially a "wide" should start at column 2.

BTW i tested it by overriding region--content.html.twig with

{%
  set classes = [
    'region',
    'region--' ~ region|clean_class,
    'grid-full',
    'layout--pass--content-wide',
  ]
%}

{% if content %}
  <div{{ attributes.addClass(classes) }} id="content">
    {{ content }}
  </div>
{% endif %}
sime’s picture

Title: Olivero: Add helper classes to have a layout larger than the parent layout » Olivero: Support wide/full width regions

I feel like the title is at odds with what the description/code have become.

shweta__sharma’s picture

StatusFileSize
new750.83 KB
new775.11 KB

Tested patch #23 and it's successfully applied the layout--pass--content-wide class is working well. The layout is now full-sized when using wide class. Attached screenshot for reference.

Before patch

before-patch

After Patch

after-patch

shweta__sharma’s picture

Status: Needs work » Needs review
sime’s picture

@shweta__sharma It would be very good in your screenshots to use the "grid" button (it's right next to the area you highlighted) to visually show the grid.

I think this patch is "needs work" for two reasons:

  1. because Olivero is not intended to be a base theme. So this patch is meaningless in my opinion without some way for a site builder to change the layout through settings.
  2. The second problem is the title of this issue is "wide/full width regions" and currently this patch only does wide.
sime’s picture

Status: Needs review » Needs work
sime’s picture

#17 review from 2 years is still applicable, I just rerolled the patch.

senzaesclusiva’s picture

This, a full grid, is a change that I have always wondered if it would be possible to implement.
Does anyone know if these patches could also work on version 10.5.8?
Thanks to anyone who can give me some suggestions.

sanket.tale made their first commit to this issue’s fork.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

Title: Olivero: Support wide/full width regions » Support wide/full width regions
Status: Needs work » Postponed

The Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.

quietone’s picture

Project: Drupal core » Olivero
Version: main » 2.x-dev
Component: Olivero theme » Code
Status: Postponed » Needs work