Needs work
Project:
Olivero
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Apr 2020 at 21:15 UTC
Updated:
2 Oct 2026 at 09:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
duneblHere is the patch
Comment #3
komalk commentedComment #4
komalk commented@DuneBL What is requirement of
it just provide the extra column from left and right side.
Comment #5
dunebl@komalkolekar : This is to provide an helper class as it is explained in the documentation here: https://paper.dropbox.com/doc/Olivero-vertical-spacing-grid--A0Nqav3A6SW...
Comment #6
mherchelComment #7
mherchelComment #8
mherchelComment #9
gauravvvv commentedI tried patch #2,
gauravmahlawat@Gauravs-Air olivero % git apply -v 0001-Add-bigger-layout-helper-class.patch
Skipped patch 'css/dist/layout/layout-bigger.css'.
Skipped patch 'css/src/layout/layout-bigger.css'.
Skipped patch 'olivero.libraries.yml'.
The patch didn't apply correctly.
Comment #10
mherchelSome work on this.
Comment #12
gauravvvv commentedlayout--content-wideIncreases the width of the column, but not overlapping the sidebar region and layout builder dialog box.Comment #13
gauravvvv commentedComment #15
sakthivel m commentedJust Re-roll the patch 9.3.x
Comment #16
Madhu kumar commentedPatch #15 applied cleanly and width of the column increased, Sharing screenshot for the reference.
Comment #17
chetanbharambe commentedVerified and tested patch #15.
Patch applied successfully but not working as expected.
Testing Steps:
# Goto: Appearance -> Apply Olivero theme
# Goto: Extend ->install layout builder
# Goto: admin/structure/types/manage/article/display
# Give the permission under the layout option and save it
# Create a content type
# Save it
# Goto: layout and inspect the element and check respective classes.
Expected Results:
# User should see below mentioned two classes after applying the patch #15
layout--content-widelayout--content-fullBoth above classes are not appearing.
Actual Results:
# Currently user is able to see only
layout--content-mediumclassPlease refer attached screenshots for the same
Not working as expected.
Can be a move to Needs Work.
Comment #18
vikashsoni commentedI have applied patch #15 applied successfully
But I can't see any changes Before patch and after patch the condition are same
For ref sharing screenshot .....
Comment #23
simeI've updated this patch to apply to the latest core. I can see the class is being used, but the layout is not using more grid than the medium, and I'm not good enough at frontend to debug this.
Comment #24
simeOK correction, it appears to be working. It still starts at column 3 but extends further to the right. I think potentially a "wide" should start at column 2.
BTW i tested it by overriding
region--content.html.twigwithComment #25
simeI feel like the title is at odds with what the description/code have become.
Comment #26
shweta__sharma commentedTested patch #23 and it's successfully applied the
layout--pass--content-wideclass is working well. The layout is now full-sized when using wide class. Attached screenshot for reference.Before patch
After Patch
Comment #27
shweta__sharma commentedComment #28
sime@shweta__sharma It would be very good in your screenshots to use the "grid" button (it's right next to the area you highlighted) to visually show the grid.
I think this patch is "needs work" for two reasons:
Comment #29
simeComment #30
sime#17 review from 2 years is still applicable, I just rerolled the patch.
Comment #31
senzaesclusiva commentedThis, a full grid, is a change that I have always wondered if it would be possible to implement.
Does anyone know if these patches could also work on version 10.5.8?
Thanks to anyone who can give me some suggestions.
Comment #34
quietone commentedThe Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.
Comment #35
quietone commented