Closed (fixed)
Project:
Drupal driver for SQL Server and SQL Azure
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Apr 2020 at 15:30 UTC
Updated:
8 May 2020 at 18:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
afireintheattic commentedPatch is attached.
Comment #3
beakerboyDo you have a test case for this? I would like to be able to force the error to happen and then ensure that your patch fixes the problem without side effects. The way I read the code, $table is always a string, never an array. Indexing the string with [0] will grab the first character from the string to see if it is a ‘#’. Somehow, some function is passing NULL in as the table name (according to the backtrace you supplied). If anything, adding
is probably the way to fix this because I think your
is_array()will always evaluate false, and the existance of temporary tables will always be false.Comment #4
beakerboyYour patch causes a failure in an existing Kernel Test
Comment #6
beakerboyI merged in my fix. Thanks for bringing this to my attention.
Comment #7
afireintheattic commentedGreat! As I'm trying to stay locked in at an RC release instead of using the dev branch, I rolled a patch file off of your fix that I can use in my composer.json until this gets rolled into a release. Thanks for the help!
Comment #8
beakerboyHere are a few core patches that have been rolled out to Drupal 9, but are still buggy in 8.8: