/**
 * Convert an item to an 'exportable'.
 */
function backup_migrate_ui_export_form($form, &$form_state, $item) {
  if ($item && function_exists('ctools_var_export')) {
    $code = ctools_var_export($item);
    $form = ctools_export_form($form_state, $code);     // EXPECTED 3 ARGUMENTS, FOUND 2.
    return $form;
  }
  return array();
}
CommentFileSizeAuthor
backup_migrate-missing-ctools-parameter.patch565 bytessolideogloria

Comments

solideogloria created an issue. See original summary.

solideogloria’s picture

solideogloria commented
Status: Active » Needs review

PHP Intelliphense is so helpful to find stuff like this.

Status: Needs review » Needs work

The last submitted patch, backup_migrate-missing-ctools-parameter.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

solideogloria’s picture

solideogloria commented

No idea what the testing failure means...

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

The test failure means that the testbot failed and needed to be ran again. I've set it to run against PHP 7.3, we'll see what it says this time.

Status: Needs review » Needs work

The last submitted patch, backup_migrate-missing-ctools-parameter.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

solideogloria’s picture

solideogloria commented

I mean that I don't know what to do with the failure information, because all I did was fix an incorrect usage of a function.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I understand, usually when that error happens it means that the test just needs to be re-ran. That didn't happen this time, so I'm trying one last time before I dig into it more.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Fixed
Parent issue: » #3116785: Plan for Backup and Migrate 7.x-3.8

Committed. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.