Other modules, e.g. "layout builder override", also alter the browse block controller.

Since both do not specify a priority in the route alter, the layout browser sometimes works, sometimes it doesnt.

CommentFileSizeAuthor
#8 route_alter_priority-3129158-8.patch794 byteskpaxman
#6 3129158--6--route-alter-priority.patch903 bytesstrykaizer

Comments

acouch created an issue. See original summary.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented

Yes, it should work.

- Create a category
- Assign a block to the category

Do you have "layout builder restrictions" enabled by any chance?
I just noticed that module overrides the same controller, which clashes with this module.

TODO: write patch which ensures layout builder browser triggers last in the routesubscriber

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Active » Closed (works as designed)
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Closed (works as designed) » Needs work
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Title: Working on 8.8.3? » Route alter priority not always after other modules
Issue summary: View changes
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Category: Feature request » Bug report
Status: Needs work » Needs review
StatusFileSize
new 3129158--6--route-alter-priority.patch903 bytes
kpaxman’s picture

kpaxman commented
Status: Needs review » Reviewed & tested by the community

Not only does the patch work so that I now see the Layout Builder Browser sidebar with the Layout Builder Restrictions module enabled, but it appears that the restrictions from Layout Builder Restrictions module are preserved!

I've marked this RTBC but this does represent only ~2 minutes of testing. :)

kpaxman’s picture

kpaxman commented
StatusFileSize
new route_alter_priority-3129158-8.patch794 bytes

Rerolled patch that applies to 8.x-1.x attached. (Code standards changes prevented me, at least, from applying the original patch.)

  • StryKaizer committed 02dc8f7 on 8.x-1.x 
    Issue #3129158 by StryKaizer, kpaxman: Route alter priority not always...
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.