Drupal 9 is coming out soon. H5P needs to be D9-ready.

CommentFileSizeAuthor
#9 deprecated_issues.patch36.2 KBjorgewray93
#3 d9-compatibility-3129142-3.patch35.39 KBdakala
#2 d9-compatibility-3129142-2.patch35.46 KBdakala

Issue fork h5p-3129142

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    dakala created an issue. See original summary.

    dakala’s picture

    dakala
    he/him
    Primary language English
    Location Fairford, Glos
    commented
    StatusFileSize
    new d9-compatibility-3129142-2.patch35.46 KB

    I needed to evaluate H5P for a project that should be D9-compatible. The attached patch allowed me to run H5P successfully.

    dakala’s picture

    dakala
    he/him
    Primary language English
    Location Fairford, Glos
    commented
    StatusFileSize
    new d9-compatibility-3129142-3.patch35.39 KB

    Re-rolled patch attached.

    Hannes Richert’s picture

    Hannes Richert commented

    Will there be an official build for a working H5P module for D9 soon? I just broke my Drupal site again and would really like to go with Drupal 9 next time.

    Elias_Gomez’s picture

    Elias_Gomez commented

    Hello Mr. Dakala, Can you explain me how where and how to put this patch on my project? I have never use any of this patches before. Thanks.

    sharique’s picture

    sharique commented

    @Elias, please check here in official documentation https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa....

    dianacastillo’s picture

    dianacastillo commented

    we tested with the patch above and it works in d9

    robcarr’s picture

    robcarr
    Primary language English
    Location Perthshire, Scotland
    commented

    Any ideas how to install H5P with Composer on a D9 site? Have added patch entry 

    "patches": {
			"drupal/h5p": {
				"Drupal 9 compatibility 3129142": "https://www.drupal.org/files/issues/2020-04-19/d9-compatibility-3129142-3.patch"
			}
		},
		"enable-patching": true,

    to composer.json (and "cweagans/composer-patches", "drupal/h5p" as a requirement etc). But can't run Composer update/install/require for this module. Rejected because H5P package requires drupal/core ^8.

    jorgewray93’s picture

    jorgewray93 commented
    StatusFileSize
    new deprecated_issues.patch36.2 KB

    I have a little issue when I put it in a site with php 7.4, I update the patch with this fix.

    robcarr’s picture

    robcarr
    Primary language English
    Location Perthshire, Scotland
    commented

    I used the approach at #3150110-40: Drupal 9 Deprecated report to install H5P via Composer (rather than try to implement the proposed patch). Seems to have worked fine

    sim_1’s picture

    sim_1
    she/her
    commented
    Status: Active » Closed (outdated)

    Marking Closed outdated since we have a working d10 version out now.