[D8] Gin Admin Theme

Thank you for applying! I added the Git instructions for non-maintainer users and the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

FILE: ...akti.kumar/work/d8/web/modules/contrib/gin/webpack.config.dev.js
----------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------
  5 | ERROR | [x] Opening parenthesis of a multi-line function call
    |       |     must be the last content on the line
  6 | ERROR | [x] Multi-line function call not indented correctly;
    |       |     expected 4 spaces but found 2
  6 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     2
  7 | ERROR | [x] Multi-line function call not indented correctly;
    |       |     expected 4 spaces but found 2
  7 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     2
  8 | ERROR | [x] Multi-line function call not indented correctly;
    |       |     expected 4 spaces but found 2
  8 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     2
  9 | ERROR | [x] Opening parenthesis of a multi-line function call
    |       |     must be the last content on the line
 10 | ERROR | [x] Multi-line function call not indented correctly;
    |       |     expected 8 spaces but found 6
 10 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found
    |       |     6
 11 | ERROR | [x] Multi-line function call not indented correctly;
    |       |     expected 8 spaces but found 6
 11 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found
    |       |     6
 12 | ERROR | [x] Closing parenthesis of a multi-line function call
    |       |     must be on a line by itself
 13 | ERROR | [x] Multi-line function call not indented correctly;
    |       |     expected 4 spaces but found 2
 14 | ERROR | [x] Closing parenthesis of a multi-line function call
    |       |     must be on a line by itself
----------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...work/d8/web/modules/contrib/gin/dist/css/gin_classic_toolbar.css
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------


FILE: ...rs/shakti.kumar/work/d8/web/modules/contrib/gin/dist/css/gin.css
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------


FILE: ...i.kumar/work/d8/web/modules/contrib/gin/dist/css/gin_toolbar.css
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------


FILE: ...ti.kumar/work/d8/web/modules/contrib/gin/dist/css/gin_accent.css
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------

Time: 144ms; Memory: 6Mb

@saschaeggi,

Apart from css some js issues also need to fixed.

/dist/js/gin_settings.js: ASCII text, with very long lines, with no line terminators
./dist/js/gin_toolbar.js: ASCII text, with very long lines, with no line terminators
./dist/js/gin_accent.js: UTF-8 Unicode text, with very long lines, with no line terminators

Yes, given that minified files aren't meant to be easily read, but to be smaller, it wouldn't make sense to ask for 80-character lines.

I will review the project in the next 12 hours.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.