Drupal 9 Readiness

The patch looks and applies well. Thanks, @Ramya Balasubramanian

Hi @Ramya Balasubramanian,

I executed drupal-check on 8.x-2.x branch and identified that we still have other drupal 9 compatibility issues. Please refer to the below list. We should fix this as the scope of this ticket.

28/28 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ -------------------------------------------------------------------------
Line modules/record_shorten/record_shorten.module
------ -------------------------------------------------------------------------
49 Call to deprecated function db_select():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container and
call select() on it. For example,
65 Call to deprecated function drupal_render():
in drupal:8.0.0 and is removed from drupal:9.0.0. Use the
68 Call to deprecated function drupal_render():
in drupal:8.0.0 and is removed from drupal:9.0.0. Use the
------ -------------------------------------------------------------------------

------ --------------------------------------------------------------------------------------------------------------------------
Line modules/record_shorten/record_shorten_views_handler_field_hostname.inc
------ --------------------------------------------------------------------------------------------------------------------------
Class record_shorten_views_handler_field_hostname was not found while trying to analyse it - autoloading is probably not
configured properly.
💡 Learn more at https://phpstan.org/user-guide/autoloading
------ --------------------------------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------------------------------------------------------------------------
Line modules/record_shorten/record_shorten_views_handler_filter_string_service.inc
------ ---------------------------------------------------------------------------------------------------------------------------------
Class record_shorten_views_handler_filter_string_service was not found while trying to analyse it - autoloading is probably not
configured properly.
💡 Learn more at https://phpstan.org/user-guide/autoloading
------ ---------------------------------------------------------------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line modules/record_shorten/src/Controller/DefaultController.php
------ -------------------------------------------------------------------------
19 Call to deprecated function db_query():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,
get a database connection injected into your service from the container
and call query() on it. For example,
------ -------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line modules/record_shorten/src/Form/RecordshortenClearAll.php
------ -------------------------------------------------------------------------
43 Call to deprecated function db_query():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,
get a database connection injected into your service from the container
and call query() on it. For example,
44 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ -------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------
Line modules/record_shorten/src/record_shorten_views_handler_field_hostname.php
------ ----------------------------------------------------------------------------------------
Class Drupal\record_shorten\views_handler_field not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
8 Class Drupal\record_shorten\views_handler_field not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
------ ----------------------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------
Line modules/record_shorten/src/record_shorten_views_handler_filter_string_service.php
------ -----------------------------------------------------------------------------------------------------
Class Drupal\record_shorten\views_handler_filter_many_to_one not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
7 Class Drupal\record_shorten\views_handler_filter_many_to_one not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
------ -----------------------------------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line modules/shorten_cs/shorten_cs.admin.inc
------ -------------------------------------------------------------------------
51 Call to deprecated function db_query():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,
get a database connection injected into your service from the container
and call query() on it. For example,
93 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ -------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line modules/shorten_cs/shorten_cs.module
------ -------------------------------------------------------------------------
44 Call to deprecated function db_query():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,
get a database connection injected into your service from the container
and call query() on it. For example,
92 Call to deprecated function db_query():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,
get a database connection injected into your service from the container
and call query() on it. For example,
------ -------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line modules/shorten_cs/src/Form/CustomServicesAddForm.php
------ -------------------------------------------------------------------------
112 Call to deprecated function db_query():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,
get a database connection injected into your service from the container
and call query() on it. For example,
134 Call to deprecated function db_query():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,
get a database connection injected into your service from the container
and call query() on it. For example,
163 Call to deprecated function drupal_render():
in drupal:8.0.0 and is removed from drupal:9.0.0. Use the
------ -------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line modules/shorten_cs/src/Form/CustomServicesDeleteForm.php
------ -------------------------------------------------------------------------
65 Call to deprecated function db_select():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container and
call select() on it. For example,
94 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
104 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
107 Call to deprecated function db_delete():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container and
call delete() on it. For example,
110 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ -------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line modules/shorten_cs/src/Form/CustomServicesEditForm.php
------ -------------------------------------------------------------------------
36 Call to deprecated function db_select():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container and
call select() on it. For example,
80 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
96 Call to deprecated function db_query():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,
get a database connection injected into your service from the container
and call query() on it. For example,
------ -------------------------------------------------------------------------

------ ----------------------------------------------------------------------------
Line modules/shortener/src/Plugin/Filter/UrlShortener.php
------ ----------------------------------------------------------------------------
109 Call to deprecated function check_url():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use UrlHelper::stripDangerousProtocols() or UrlHelper::filterBadProtocol()
instead. UrlHelper::stripDangerousProtocols() can be used in conjunction
with \Drupal\Component\Render\FormattableMarkup and an @variable
placeholder which will perform the necessary escaping.
UrlHelper::filterBadProtocol() is functionality equivalent to check_url()
apart from the fact it is protected from double escaping bugs. Note that
this method no longer marks its output as safe.
117 Call to deprecated function check_url():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use UrlHelper::stripDangerousProtocols() or UrlHelper::filterBadProtocol()
instead. UrlHelper::stripDangerousProtocols() can be used in conjunction
with \Drupal\Component\Render\FormattableMarkup and an @variable
placeholder which will perform the necessary escaping.
UrlHelper::filterBadProtocol() is functionality equivalent to check_url()
apart from the fact it is protected from double escaping bugs. Note that
this method no longer marks its output as safe.
------ ----------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------
Line shorten.module
------ -----------------------------------------------------------------------------------
93 Call to deprecated method substr() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_substr() instead.
99 Call to deprecated method substr() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_substr() instead.
136 Call to deprecated method strtoupper() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strtoupper() instead.
176 Call to deprecated method substr() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_substr() instead.
176 Call to deprecated method substr() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_substr() instead.
433 Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strlen() instead.
435 Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strlen() instead.
436 Call to deprecated method substr() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_substr() instead.
------ -----------------------------------------------------------------------------------

------ -------------------------------------------------------------------------------
Line src/Form/ShortenShortenForm.php
------ -------------------------------------------------------------------------------
90 Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strlen() instead.
115 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ -------------------------------------------------------------------------------

[ERROR] Found 39 errors

Please review the patch.

updated the correct target branch

Ran the drupal-check & it reports lots of errors after applying the patch.

shorten git/8.x-2.x*  
❯ drupal-check -ad .
 28/28 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
  Line   modules/record_shorten/record_shorten.views_default.inc                                                                              
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
  11     Function record_shorten_views_default_views not found while trying to analyse it - autoloading is probably not configured properly.  
  12     Instantiated class view not found.                                                                                                   
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   modules/record_shorten/record_shorten_views_handler_field_hostname.inc                                                                         
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------- 
         Class record_shorten_views_handler_field_hostname was not found while trying to analyse it - autoloading is probably not configured properly.  
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   modules/record_shorten/record_shorten_views_handler_filter_string_service.inc                                                                         
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------ 
         Class record_shorten_views_handler_filter_string_service was not found while trying to analyse it - autoloading is probably not configured properly.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   modules/record_shorten/src/Controller/DefaultController.php                   
 ------ ------------------------------------------------------------------------------ 
  23     \Drupal calls should be avoided in classes, use dependency injection instead  
  27     \Drupal calls should be avoided in classes, use dependency injection instead  
  28     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ---------------------------------------------------------------------------------------- 
  Line   modules/record_shorten/src/record_shorten_views_handler_field_hostname.php              
 ------ ---------------------------------------------------------------------------------------- 
         Class Drupal\record_shorten\views_handler_field not found and could not be autoloaded.  
 ------ ---------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------- 
  Line   modules/record_shorten/src/record_shorten_views_handler_filter_string_service.php                    
 ------ ----------------------------------------------------------------------------------------------------- 
         Class Drupal\record_shorten\views_handler_filter_many_to_one not found and could not be autoloaded.  
 ------ ----------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------------- 
  Line   modules/shorten_cs/shorten_cs.admin.inc                                                                                    
 ------ --------------------------------------------------------------------------------------------------------------------------- 
  13     Function theme_shorten_cs_admin not found while trying to analyse it - autoloading is probably not configured properly.    
  15     Function shorten_cs_services_table not found.                                                                              
  21     Function shorten_cs_edit_form not found while trying to analyse it - autoloading is probably not configured properly.      
  29     Function shorten_cs_edit not found while trying to analyse it - autoloading is probably not configured properly.           
  30     Function shorten_cs_add_form not found.                                                                                    
  48     Function shorten_cs_edit_validate not found while trying to analyse it - autoloading is probably not configured properly.  
  51     Function form_set_error not found.                                                                                         
  56     Function form_set_error not found.                                                                                         
  63     Function form_set_error not found.                                                                                         
  73     Function shorten_cs_edit_submit not found while trying to analyse it - autoloading is probably not configured properly.    
 ------ --------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------- 
  Line   modules/shorten_cs/shorten_cs.module  
 ------ -------------------------------------- 
  21     Constant MENU_LOCAL_TASK not found.   
  28     Constant MENU_CALLBACK not found.     
  36     Constant MENU_CALLBACK not found.     
 ------ -------------------------------------- 

 ------ ------------------------------------------------------------------------------ 
  Line   modules/shorten_cs/src/Controller/DefaultController.php                       
 ------ ------------------------------------------------------------------------------ 
  16     \Drupal calls should be avoided in classes, use dependency injection instead  
  17     \Drupal calls should be avoided in classes, use dependency injection instead  
  21     \Drupal calls should be avoided in classes, use dependency injection instead  
  22     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
  Line   modules/shorten_cs/src/Form/CustomServicesAddForm.php                                                                               
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
  23     Drupal\shorten_cs\Form\CustomServicesAddForm::__construct() does not call parent constructor from Drupal\Core\Form\ConfigFormBase.  
  63     Variable $form in isset() always exists and is not nullable.                                                                        
  118    \Drupal calls should be avoided in classes, use dependency injection instead                                                        
  134    \Drupal calls should be avoided in classes, use dependency injection instead                                                        
  166    \Drupal calls should be avoided in classes, use dependency injection instead                                                        
  180    \Drupal calls should be avoided in classes, use dependency injection instead                                                        
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   modules/shorten_cs/src/Form/CustomServicesDeleteForm.php                      
 ------ ------------------------------------------------------------------------------ 
  98     \Drupal calls should be avoided in classes, use dependency injection instead  
  100    \Drupal calls should be avoided in classes, use dependency injection instead  
  101    \Drupal calls should be avoided in classes, use dependency injection instead  
  107    \Drupal calls should be avoided in classes, use dependency injection instead  
  110    \Drupal calls should be avoided in classes, use dependency injection instead  
  111    \Drupal calls should be avoided in classes, use dependency injection instead  
  117    \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
  Line   modules/shorten_cs/src/Form/CustomServicesEditForm.php                                                                               
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
  18     Drupal\shorten_cs\Form\CustomServicesEditForm::__construct() does not call parent constructor from Drupal\Core\Form\ConfigFormBase.  
  48     \Drupal calls should be avoided in classes, use dependency injection instead                                                         
  77     \Drupal calls should be avoided in classes, use dependency injection instead                                                         
  84     \Drupal calls should be avoided in classes, use dependency injection instead                                                         
  86     \Drupal calls should be avoided in classes, use dependency injection instead                                                         
  90     \Drupal calls should be avoided in classes, use dependency injection instead                                                         
  116    \Drupal calls should be avoided in classes, use dependency injection instead                                                         
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------- 
  Line   modules/shortener/src/Plugin/Filter/UrlShortener.php                        
 ------ ---------------------------------------------------------------------------- 
  89     Function _shortener_url_behavior not found.                                 
  109    Call to deprecated function check_url():                                    
         in drupal:8.0.0 and is removed from drupal:9.0.0.                           
         Use UrlHelper::stripDangerousProtocols() or UrlHelper::filterBadProtocol()  
         instead. UrlHelper::stripDangerousProtocols() can be used in conjunction    
         with \Drupal\Component\Render\FormattableMarkup and an @variable            
         placeholder which will perform the necessary escaping.                      
         UrlHelper::filterBadProtocol() is functionality equivalent to check_url()   
         apart from the fact it is protected from double escaping bugs. Note that    
         this method no longer marks its output as safe.                             
  117    Call to deprecated function check_url():                                    
         in drupal:8.0.0 and is removed from drupal:9.0.0.                           
         Use UrlHelper::stripDangerousProtocols() or UrlHelper::filterBadProtocol()  
         instead. UrlHelper::stripDangerousProtocols() can be used in conjunction    
         with \Drupal\Component\Render\FormattableMarkup and an @variable            
         placeholder which will perform the necessary escaping.                      
         UrlHelper::filterBadProtocol() is functionality equivalent to check_url()   
         apart from the fact it is protected from double escaping bugs. Note that    
         this method no longer marks its output as safe.                             
 ------ ---------------------------------------------------------------------------- 

 ------ ------------------------------------------ 
  Line   shorten.module                            
 ------ ------------------------------------------ 
  263    Function shurly_shorten not found.        
  299    Caught class RequestException not found.  
  300    Variable $result might not be defined.    
 ------ ------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Controller/DefaultController.php                                          
 ------ ------------------------------------------------------------------------------ 
  16     \Drupal calls should be avoided in classes, use dependency injection instead  
  17     \Drupal calls should be avoided in classes, use dependency injection instead  
  21     \Drupal calls should be avoided in classes, use dependency injection instead  
  22     \Drupal calls should be avoided in classes, use dependency injection instead  
  26     \Drupal calls should be avoided in classes, use dependency injection instead  
  27     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Form/ShortenAdminForm.php                                                 
 ------ ------------------------------------------------------------------------------ 
  39     \Drupal calls should be avoided in classes, use dependency injection instead  
  48     \Drupal calls should be avoided in classes, use dependency injection instead  
  49     \Drupal calls should be avoided in classes, use dependency injection instead  
  82     \Drupal calls should be avoided in classes, use dependency injection instead  
  85     \Drupal calls should be avoided in classes, use dependency injection instead  
  96     \Drupal calls should be avoided in classes, use dependency injection instead  
  103    \Drupal calls should be avoided in classes, use dependency injection instead  
  109    \Drupal calls should be avoided in classes, use dependency injection instead  
  118    \Drupal calls should be avoided in classes, use dependency injection instead  
  131    \Drupal calls should be avoided in classes, use dependency injection instead  
  142    \Drupal calls should be avoided in classes, use dependency injection instead  
  153    \Drupal calls should be avoided in classes, use dependency injection instead  
  162    \Drupal calls should be avoided in classes, use dependency injection instead  
  165    \Drupal calls should be avoided in classes, use dependency injection instead  
  166    \Drupal calls should be avoided in classes, use dependency injection instead  
  173    \Drupal calls should be avoided in classes, use dependency injection instead  
  174    Variable $services might not be defined.                                      
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Form/ShortenKeysForm.php                                                  
 ------ ------------------------------------------------------------------------------ 
  44     \Drupal calls should be avoided in classes, use dependency injection instead  
  49     \Drupal calls should be avoided in classes, use dependency injection instead  
  54     \Drupal calls should be avoided in classes, use dependency injection instead  
  59     \Drupal calls should be avoided in classes, use dependency injection instead  
  64     \Drupal calls should be avoided in classes, use dependency injection instead  
  69     \Drupal calls should be avoided in classes, use dependency injection instead  
  74     \Drupal calls should be avoided in classes, use dependency injection instead  
  79     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Block/ShortenBlock.php                                             
 ------ ------------------------------------------------------------------------------ 
  34     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Block/ShortenCurrentPage.php                                       
 ------ ------------------------------------------------------------------------------ 
  35     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

                                                                                                                        
 [ERROR] Found 85 errors                                                                                                
                           

Added new patch. Please review!!!

Patch did not apply. Re-rolled patch. Please review!

patch #12 works fine. thanks @Suresh Prabhu Parkala

+1

Committed. Thanks👍🏻

Update patch #12 to support new Drupal standard for module info files
Work for me

@Neslee Any plans for creating a new release for 8.2.x?

Thank you,