The on-page documentation for the Redirect Domain submodule (/admin/config/search/redirect/domain) is not very clear and can lead to records not being saved even though it says "The domain redirects have been saved." For example, the "from domain" value is required even though it says the record is saved when it isn't filled in and the field does not indicate it is required.

Proposal

  • Make the "from domain" value optional.
  • Show a warning message if the "sub-path" or "destination" values are empty.
CommentFileSizeAuthor
#7 3127556-7.patch739 bytesmohit.bansal623
#6 3127556-5.patch739 bytesmohit.bansal623
#4 3127556-4.patch541 bytesmohit.bansal623

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Redirect Domain says it saves records when it doesn't » Make "from domain" optional in domain redirects
Issue summary: View changes
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Title: Make "from domain" optional in domain redirects » Mark all fields as required when adding a domain redirect

I think the title should read that the "from" domain should be marked as required. In fact, all the fields should be.

mohit.bansal623’s picture

mohit.bansal623 commented
Status: Active » Needs review
StatusFileSize
new 3127556-4.patch541 bytes

I have made "from" textfield as required as without filling any value, the success message prompt up. It should be mandatory if we are adding domain redirect, without from nothing can be done.

Status: Needs review » Needs work

The last submitted patch, 4: 3127556-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mohit.bansal623’s picture

mohit.bansal623 commented
StatusFileSize
new 3127556-5.patch739 bytes

As I see, destination should be mandatory as in submit function it has the condition otherwise the row will not be getting saved. Making all 3 fields mandatory now.

mohit.bansal623’s picture

mohit.bansal623 commented
Status: Needs work » Needs review
StatusFileSize
new 3127556-7.patch739 bytes

Status: Needs review » Needs work

The last submitted patch, 7: 3127556-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.