Problem/Motivation

Follow up #3117662: Several comments have sentences with extra periods at the end

Proposed resolution

https://github.com/pfrenssen/coder/pull/101

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Assigned: jungle » Unassigned
Issue summary: View changes
Status: Active » Needs review
iyyappan.govind’s picture

iyyappan.govind
he/him
Primary language Tamil
Location Chennai, India
commented
iyyappan.govind’s picture

iyyappan.govind
he/him
Primary language Tamil
Location Chennai, India
commented

How can I test this?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

Left some comments on the PR why I think we need to do this on existing comment sniffs instead.

iyyappan.govind’s picture

iyyappan.govind
he/him
Primary language Tamil
Location Chennai, India
commented
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Do we need to implement this explicitly in Coder?

Can we use SlevomatCodingStandard.Commenting.ForbiddenComments instead?

quietone’s picture

quietone commented

I've implement the suggested in #7 in core. #3486996: Fix extra periods at the end of comment lines

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

As this coding standard should apply to all Drupal code we should do the same Slevomat sniff with config in Coder's ruleset.xml file.

Core is getting out of sync with Coder rules again ... please always make pull requests against Coder as well when you change core's phpcs.xml.dist file, so that we have the same standards everywhere.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Fixed
Issue tags: +Vienna2025

Merged https://github.com/pfrenssen/coder/pull/270 . Used the wrong issue number in the commit to #3486996: Fix extra periods at the end of comment lines, but should not matter.

I tweaked the regex to allow 3 dots at the end and only target 2 dots.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.