Problem/Motivation

CommentFileSizeAuthor
#23 simplenews.coding-standards.3125565-23.patch14.39 KBadamps
#18 coding_standard_fixes-3125565-18.patch75.01 KBurvashi_vora
#14 3125565-14.patch2.03 KBsuresh prabhu parkala
#11 simplewnews.coding-standard.3125565-11.patch4.02 KBadamps
#8 3125565-7.patch2.46 KBmaithri shetty
#6 interdiff_2_3.txt127.42 KBrassoni
#6 3125565-3.patch126.84 KBrassoni
#3 3125565-2.patch2.46 KBmaithri shetty

Issue fork simplenews-3125565

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Maithri Shetty created an issue. See original summary.

maithri shetty’s picture

maithri shetty commented
Status: Active » Needs review
maithri shetty’s picture

maithri shetty commented
StatusFileSize
new 3125565-2.patch2.46 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3125565-2.patch, failed testing. View results

rassoni’s picture

rassoni commented
Assigned: Unassigned » rassoni
rassoni’s picture

rassoni commented
Assigned: rassoni » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3125565-3.patch126.84 KB
new interdiff_2_3.txt127.42 KB

t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead issue fixed

Status: Needs review » Needs work

The last submitted patch, 6: 3125565-3.patch, failed testing. View results

maithri shetty’s picture

maithri shetty commented
Status: Needs work » Needs review
StatusFileSize
new 3125565-7.patch2.46 KB

Status: Needs review » Needs work

The last submitted patch, 8: 3125565-7.patch, failed testing. View results

adamps’s picture

adamps commented
Version: 8.x-2.x-dev » 3.x-dev
adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new simplewnews.coding-standard.3125565-11.patch4.02 KB

  • AdamPS committed 417bce3 on 3.x 
    Issue #3125565 by Maithri Shetty, Rashmisoni, AdamPS: Phpcs coding...
adamps’s picture

adamps commented
Status: Needs review » Needs work

I have fixed some of the problems. Leaving the issue open as others still remain. I'm happy to commit patches that have test passes.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3125565-14.patch2.03 KB

Please review.

adamps’s picture

adamps commented
Issue summary: View changes
Status: Needs review » Active
urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora
Status: Active » Needs work

Hi,

I am working on this.

urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned
Status: Needs work » Needs review
StatusFileSize
new coding_standard_fixes-3125565-18.patch75.01 KB

Hi,

Please review this patch.

Thanks

adamps’s picture

adamps commented
Version: 3.x-dev » 4.x-dev
adamps’s picture

adamps commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Needs updating for 4.x

urvashi_vora’s picture

urvashi_vora commented
Issue tags: +Needs issue summary update

Also, the issue summary should describe, what the issue is and what we are trying to fix, hence adding a tag for the same.

zkhan.aamir’s picture

zkhan.aamir commented
Issue summary: View changes
Issue tags: -Needs issue summary update +Coding standards

Issue summary updated

adamps’s picture

adamps commented
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new simplenews.coding-standards.3125565-23.patch14.39 KB

Automatic fixes

  • AdamPS committed dab97b06 on 4.x 
    Issue #3125565 by AdamPS, urvashi_vora: Phpcs coding standard
adamps’s picture

adamps commented
Status: Needs review » Active

Still some manual fixes to do.

We don't care about the "best practice" only the "standard=Drupal".

davps made their first commit to this issue’s fork.

davps opened merge request !65