CommentFileSizeAuthor
#9 coding-standards-3124358-9.patch5.63 KBchakkche
#7 interdiff_4-7.txt316 bytesGuilherme Rabelo
#7 3124358-7.patch10.22 KBGuilherme Rabelo
#4 3124358-4.patch10.09 KBanabpv
#2 3124358-2.patch8.81 KBmaithri shetty

Issue fork responsive_slideshow-3124358

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    Maithri Shetty created an issue. See original summary.

    maithri shetty’s picture

    maithri shetty commented
    Status: Active » Needs review
    StatusFileSize
    new 3124358-2.patch8.81 KB
    anabpv’s picture

    anabpv
    she/her
    Location Portugal 🇵🇹
    commented
    Assigned: Unassigned » anabpv

    I will review this

    anabpv’s picture

    anabpv
    she/her
    Location Portugal 🇵🇹
    commented
    StatusFileSize
    new 3124358-4.patch10.09 KB

    Applied patch from #2.
    Ran phpcs and phpcbf and fixed the errors and warnings.
    Also commented unused variables on responsive_slideshow.module.

    Waiting for review.

    anabpv’s picture

    anabpv
    she/her
    Location Portugal 🇵🇹
    commented
    Assigned: anabpv » Unassigned
    Guilherme Rabelo’s picture

    Guilherme Rabelo commented
    Assigned: Unassigned » Guilherme Rabelo
    Status: Needs review » Needs work

    Hi, when i run phpcs, shows me the follow error:

    FILE: /home/guilhermerabelo/Contribution/Project77/recommended-project/web/modules/contrib/responsive_slideshow/responsive_slideshow.info.yml
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
---------------------------------------------------------------------------------------------------------------------------------------------

    I will fixe this warning.

    Guilherme Rabelo’s picture

    Guilherme Rabelo commented
    Assigned: Guilherme Rabelo » Unassigned
    Status: Needs work » Needs review
    StatusFileSize
    new 3124358-7.patch10.22 KB
    new interdiff_4-7.txt316 bytes

    Hi, my patch fixe the property is missing in the info.yml file warning, and when i run phpcs command again, didn't shows me any coding standards erros.
    Kindly review it.

    chakkche’s picture

    chakkche commented
    Assigned: Unassigned » chakkche

    I will review this.

    chakkche’s picture

    chakkche commented
    Assigned: chakkche » Unassigned
    StatusFileSize
    new coding-standards-3124358-9.patch5.63 KB

    The patch in comment #7 is getting error as it is being applied for tag 8.x-1.1 where as 8.x-1.2 is the latest tag. So created a patch for latest tag. Please review it.

    tmaiochi’s picture

    tmaiochi commented
    Assigned: Unassigned » tmaiochi

    I'll review this!

    tmaiochi’s picture

    tmaiochi commented
    Assigned: tmaiochi » Unassigned
    Status: Needs review » Reviewed & tested by the community

    I applied patch from #9, and I was on tag 8.x-1.2 which is the last tag, and all messages from PHPCS was fixed, so I'm moving to RTBC!

    anjalisudhi’s picture

    anjalisudhi commented
    Version: 8.x-1.2 » 11.1.x-dev
    Status: Reviewed & tested by the community » Fixed

    This issue has been resolved. A new release with the fix has been published.

    Now that this issue is closed, review the contribution record.

    As a contributor, attribute any organization that helped you, or if you volunteered your own time.

    Maintainers, credit people who helped resolve this issue.

    anjalisudhi’s picture

    anjalisudhi commented
    Status: Fixed » Closed (fixed)