Motivation

Refer to https://www.drupal.org/project/olivero/issues/3124297:
Since Olivero is supposed to be default theme in d9 core https://www.drupal.org/about/strategic-initiatives#olivero - we have to modify "Standard" installation profile a little bit, to make Olivero looking great from the box & in the pair with "Standard" profile.

Design is here:

Olivero Article CT Design

Problems

  • No matched image style
  • CT Article - Default display - Image field is using wrong image style

Proposed resolution

  • Create a new image style: effect - scale, dimensions - width 1090px and height not set.
  • Link new image style to the "Image" field of CT Article - Default display

Comments

kostyashupenko created an issue. See original summary.

kostyashupenko’s picture

Issue summary: View changes
kostyashupenko’s picture

Issue summary: View changes
kostyashupenko’s picture

Issue summary: View changes
kostyashupenko’s picture

Assigned: kostyashupenko » Unassigned
Status: Needs work » Needs review
StatusFileSize
new1.45 KB

Status: Needs review » Needs work

The last submitted patch, 5: 3124339-5.patch, failed testing. View results

swatichouhan012’s picture

Status: Needs work » Needs review
StatusFileSize
new2.75 KB
new987 bytes

correct image-style number in test files.

Status: Needs review » Needs work

The last submitted patch, 7: 3124339-7.patch, failed testing. View results

andypost’s picture

Status: Needs work » Needs review
StatusFileSize
new756 bytes
new3.49 KB

Fix broken test

kristen pol’s picture

Assigned: Unassigned » kristen pol

Assigning to myself to take a look.

kristen pol’s picture

Thanks for the patch.

For reference, the new image style from the patch is added here:

core/profiles/standard/config/install/image.style.extra_large.yml

The other image styles in the standard profile are:

core/profiles/standard/config/optional/image.style.max_1300x1300.yml
core/profiles/standard/config/optional/image.style.max_650x650.yml
core/profiles/standard/config/optional/image.style.max_325x325.yml
core/profiles/standard/config/optional/image.style.max_2600x2600.yml

The previous image style that was used for the standard profile was:

core/modules/image/config/install/image.style.large.yml

Other image styles are in these directories:

core/profiles/demo_umami/config/install
core/profiles/demo_umami/config/optional
core/modules/image/migrations
core/modules/image/config/install
core/modules/media_library/config/install

The new image style is the only "extra_large" image style. Comparing the extra_large image style to the previously-used large image style:

  • name: large vs extra_large
  • label: 'Large (480×480)' vs 'Extra Large (1090xNone)'
  • weight: 0 vs 1
  • width: 480 vs 1090
  • height: 480 vs null

I'm not sure if the weight matters as other image styles have a weight of 0 or 1 or 3.

It's interesting because the existing image styles are all over the map on the widths for "small", "medium", or "large" image styles:

  • small widths: 300, 768
  • medium widths: 220, 266, 600, 1024, 1200
  • large widths: 480, 768, 900, 1440, 1536, 2880

so not sure if calling this one "extra_large" makes sense but it is bigger than the image style with the machine name "large".

Thoughts:

  1. Does it make sense to put the extra_large image style with the thumbnail, medium, and large image styles since it's named to reflect the image style naming convention for those?
  2. If not, should it be named to reflect its aspect ratio like some of the other image styles? e.g. image.style.large_21_9.yml, image.style.large_3_2_768x512.yml

Other than that, the patch seems fine. I haven't tested it yet.

kristen pol’s picture

Assigned: kristen pol » Unassigned
mherchel’s picture

The image style is already added to core in #3153009: Create "Wide" image style for standard profile. Note that we shouldn't change the standard profile until Olivero is set to be the default theme in core.

kristen pol’s picture

kristen pol’s picture

Status: Needs review » Closed (duplicate)

Whoops. Meant to mark it has duplicate. This issue is older but it was fixed in #3153009: Create "Wide" image style for standard profile.