CommentFileSizeAuthor
#14 backup_migrate-n3124193-14.patch4.74 KBdamienmckenna
#12 3124193_12.patch4.82 KBvsujeetkumar
#9 interdiff_2-9.txt2.52 KBvsujeetkumar
#9 3124193_9.patch4.83 KBvsujeetkumar
#2 3124193-2.patch6.73 KBneslee canil pinto

Comments

Neslee Canil Pinto created an issue. See original summary.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3124193-2.patch6.73 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3124193-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs work » Needs review

Patch applied successfully , dont know why test fails.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

It would be worth running the tests locally and seeing what the error messages are in the HTML output.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented

Ok @damien

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Needs to be rerolled.

vsujeetkumar’s picture

vsujeetkumar commented
Assigned: Unassigned » vsujeetkumar
vsujeetkumar’s picture

vsujeetkumar commented
Assigned: vsujeetkumar » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 3124193_9.patch4.83 KB
new interdiff_2-9.txt2.52 KB

Re-roll patch created, Please review.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 8.x-4.x-dev » 5.0.x-dev
Status: Needs review » Needs work

Thank you. Could you please reroll the patch for the 5.0.x branch? The files have moved around a little (search for the matching filenames) but it's mostly the same codebase.

vsujeetkumar’s picture

vsujeetkumar commented
Assigned: Unassigned » vsujeetkumar
vsujeetkumar’s picture

vsujeetkumar commented
Assigned: vsujeetkumar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3124193_12.patch4.82 KB

@DamienMcKenna Re-roll patch created for 5.0.x-dev, Please review.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3143649: Plan for Backup and Migrate 5.0.0
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new backup_migrate-n3124193-14.patch4.74 KB

Rerolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thank you all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.