Add test cases for OpenStack Network Interface

@nileshaddweb

Thank you for adding the test case. Now that we merged the patch at #3126453, we need to create test cases based on it.

@yas

I refactored the code for testcase.

Please test new patch.

Thanks

@jigishaddweb

Thank you for the refactoring. I found the following.

1. This code should be deleted from OpenStackNetworkInterfaceTest, and Drupal\Tests\aws_cloud\Functional\Ec2\NetworkInterfaceTest::createRandomSubnets() should be moved into Drupal\Tests\aws_cloud\Traits\AwsCloudTestFormDataTrait.
   

   +++ b/modules/cloud_service_providers/openstack/tests/src/Functional/OpenStack/OpenStackNetworkInterfaceTest.php
   @@ -0,0 +1,410 @@
   
   +  /**
   +   * Create random subnets.
   +   *
   +   * @return array
   +   *   Random subnets array.
   +   *
   +   * @throws \Exception
   +   */
   +  private function createRandomSubnets(): array {
   +
   +    $subnets = [];
   +    $count = random_int(1, 10);
   +    for ($i = 0, $num = 1; $i < $count; $i++, $num++) {
   +      $subnets[] = [
   +        'SubnetId' => 'subnet-' . $this->getRandomId(),
   +        'Tags' => [
   +          [
   +            'Key' => 'Name',
   +            'Value' => sprintf('subnet-random-data #%d - %s - %s', $num, date('Y/m/d H:i:s'), $this->random->name(32, TRUE)),
   +          ],
   +        ],
   +      ];
   +    }
   +
   +    return $subnets;
   +  }
   

2. This code should be deleted from OpenStackNetworkInterfaceTest, and Drupal\Tests\aws_cloud\Functional\Ec2\NetworkInterfaceTest::updateSubnetsToMockData() should be moved into Drupal\Tests\aws_cloud\Traits\AwsCloudTestMockTrait.
   

   +++ b/modules/cloud_service_providers/openstack/tests/src/Functional/OpenStack/OpenStackNetworkInterfaceTest.php
   @@ -0,0 +1,410 @@
   
   +  /**
   +   * Update VPCs and subnets to mock data.
   +   *
   +   * @param array $subnets
   +   *   The subnets array.
   +   */
   +  private function updateSubnetsToMockData(array $subnets): void {
   +    $mock_data = $this->getMockDataFromConfig();
   +    $mock_data['DescribeSubnets']['Subnets'] = $subnets;
   +    $this->updateMockDataToConfig($mock_data);
   +  }
   +
   +}
   

@yas

Thank you for reviewing the patch.

I changed the code as per your comment.

Please review updated patch.

Thanks

@jigishaddweb

Unfortunately all tests have not been passed successfully. Probably that's the system's failure. I'll re-test it.

@jigishaddweb

Thank you for the update. Now the tests are passed successfully. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

@jigishaddweb

Could you please re-create the patch? I had the following error while merging the patch:

error: patch failed: modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/CloudServerTemplateTest.php:3
error: modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/CloudServerTemplateTest.php: patch does not apply
error: patch failed: modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/InstanceTest.php:2
error: modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/InstanceTest.php: patch does not apply

@yas

Thank you for testing the patch.

I recreated the patch. Please review new patch.

Thanks

@jigishaddweb

Thank you for the update. Now it looks good. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.