• Refactor test cases - remove and integrate redundant code against AWS Cloud and other cloud service provider test cases.
CommentFileSizeAuthor
#6 3126453-6.patch692.95 KByas
#5 3126453-5.patch693.01 KByas
#2 3126453-2.patch695.17 KByas
#2 screenshot 2020-04-09 13.17.28.png2.6 MByas
#2 screenshot 2020-04-09 13.21.18.png3.44 MByas
#2 screenshot 2020-04-09 13.17.38.png1.48 MByas
#2 screenshot 2020-04-09 13.05.32.png3.16 MByas

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new screenshot 2020-04-09 13.05.32.png3.16 MB
new screenshot 2020-04-09 13.17.38.png1.48 MB
new screenshot 2020-04-09 13.21.18.png3.44 MB
new screenshot 2020-04-09 13.17.28.png2.6 MB
new 3126453-2.patch695.17 KB

28.png
18.png
38.png

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas, thank you for this large patch. I reviewed it and it looks good.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for your review.

@xiaohua-guan, @masami

What do you think?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3126453-5.patch693.01 KB

Updated the patch to follow up the latest code.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3126453-6.patch692.95 KB
masami’s picture

masami commented

@yas
The patch looks great for me.

xiaohua guan’s picture

xiaohua guan commented

@yas

The patch file looks good to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie @masami @guan

Thank you for your review. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 8b88046 on 8.x-1.x 
    Issue #3126453 by yas, baldwinlouie, Masami, Xiaohua Guan: Refactor test...

  • yas committed 41484d6 on 8.x-2.x 
    Issue #3126453 by yas, baldwinlouie, Masami, Xiaohua Guan: Refactor test...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.