Closed (outdated)
Project:
Drupal core
Version:
9.1.x-dev
Component:
javascript
Priority:
Major
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
31 Mar 2020 at 09:55 UTC
Updated:
27 Oct 2021 at 10:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
lauriiiI used following commands for generating the patch:
yarn upgradeyarn run build:jsyarn run build:cssyarn lint:cssyarn lint:core-js-passingComment #4
lauriiiUpdated packages again.
Comment #5
bnjmnmRan
yarn outdatedand autoprefixer has a 9.7.6 update available as of 16 hours ago 🙂Comment #6
abhisekmazumdarUpdated Patch.
Comment #7
abhisekmazumdarComment #9
abhisekmazumdarComment #10
longwaveI applied #6 and then reran the commands in #2 and there are no differences, therefore we are on the latest versions for everything and this is good to go.
Comment #11
catchDo we really want this @babel/helplers stuff in core js? It is very possible I've missed something and we do, but first time I've seen it.
Comment #12
lauriiiIt seems like they've added the directive to the beginning of the function body in https://github.com/babel/babel/pull/11049 to make it easier for other Babel plugins to identify that this code doesn't have to be processed since it's generated by Babel itself. I'm not sure if there's a strong urge for us to get out of our way to remove it even though it isn't necessarily something we need in our production code.
Comment #13
xjmI also had the same reaction as #11.
We should probably do #3107926: Update stylelint to ^13.0.0 first and then regenerate some updates -- postponing on that issue.
Comment #14
nod_With nodejs 12.17.0 our js compiling script is broken, upgrading all babel dependencies fixes thing, but like said in #11 there is some extra stuff in the generated JS.
#3143289: Upgrade babel dependencies (yarn run build:js broken)
Comment #15
dwwShould this become a META and we set #3118741: [Security] Update yarn dependencies to fix security issues as another child?
Comment #16
dwwRemoving duplicate
devDependenciescolumn to try to get the summary to fit better instead of crashing into sidebar so much. ;)Turning this into a meta since there are multiple children to help scope.
Comment #17
dwwRemoving empty CHANGELOG column.
Comment #18
xjmSo @dww I think on 9.0.x we should be using the full update here. It's 8.9.x and especially 8.8.x that need more careful updates to reduce risk of regressions.
Comment #19
alexpottAdded two more children... #3145177: Update JS dev dependencies for latest major versions and #3145197: Update eslint to v7 and prettier to v2 when airbnb standard supports it
Comment #21
lauriii