Fix 'Drupal.Semantics.FunctionT.NotLiteralString' coding standard

Some of these will be fixed by #3143339: Clean up the arguments of calls to WebAssert::titleEquals() and AssertLegacyTrait::assertTitle()

Also a lot of false positives here, e.g. the definition of t() itself, a test of the TranslatableMarkup object, etc.

Here are some examples of the lines identified by this sniff.

• $translatable_label = new TranslatableMarkup($this->randomMachineName());
• new TranslatableMarkup(new TranslatableMarkup('foo', [], [], $translation));
• $label = $this->t($group, [], ['context' => 'breakpoint']);

Perhaps this sniff is one not to implement? Or does it need more work?

This one seems straightforward as it's adding the ignore line.

When I read the issue title I was like uhoh I hope I agree with the implementation of this rule by coder as some of coder's opinions are highly debatable. So I reviewed all the places where we are adding skips and I think this shows the value of the rule. There are things we would not have done in core if this rule was present - so that is great. However that means I think we should add follow-ups to address all these places where we are skipping the rule and should not be.

Made lots of followups and committed the suggestions made in the MR. Setting back to NR.

Should todos be placed next to the ignore comments?

Removing the follow up tag as appears @quietone did all that.

Disregard my comment in #19 seeing other phpcs ignores I don't see todos.

The MR has conflicts with changes in HEAD

Rebased and added ignore for two recent changes.

Rebase seems fine.

Another question on the MR.

For the 1 suggestion from @catch in the MR.

Feedback appears to be addressed.

Couple of questions on the MR

I expanded the followup to include all three methods that raised questions, \Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition::label, \Drupal\breakpoint\BreakpointManager::getGroupLabel, and \Drupal\breakpoint\Breakpoint::getLabel. That will allow the sniff to be enabled, and prevent further violations, and leave the existing code as is.

Resolved most of the threads but the 3 could use some feedback on.

Rebased.

Resolved most of the threads but the 3 could use some feedback on.

Feedback on what? What are the questions that need to be answered?

Needs manual rebase.

As mentioned there are a number of these floating around if you want to focus on one and ping that to me I'll prioritize it @quietone, so you don't have to keep rebasing a dozen of them.

I have thought about that but I also like that the changes are less when rebasing frequently.

Rebase and add more ignore lines.

No worries just made the offer to help. But if you don't mind rebasing I'll keep reviewing.

Latest rebase seems fine.

Committed to 11.x - fixed

It looks like code duplication was made at core/modules/migrate/tests/src/Kernel/MigrateEntityContentValidationTest.php
There is fix at #3227598: Remove remaining uses of FormattableMarkup in kernel test assertions.