Clean up the arguments of calls to WebAssert::titleEquals() and AssertLegacyTrait::assertTitle()

1. +++ b/core/modules/comment/tests/src/Functional/CommentPreviewTest.php
   @@ -67,9 +67,9 @@ public function testCommentPreview() {
   -    $this->assertTitle(t('Preview comment | Drupal'), 'Page title is "Preview comment".');
   -    $this->assertText($edit['subject[0][value]'], 'Subject displayed.');
   -    $this->assertText($edit['comment_body[0][value]'], 'Comment displayed.');
   +    $this->assertTitle('Preview comment | Drupal');
   +    $this->assertText($edit['subject[0][value]']);
   +    $this->assertText($edit['comment_body[0][value]']);
   
   @@ -101,9 +101,9 @@ public function testCommentPreviewDuplicateSubmission() {
   -    $this->assertTitle(t('Preview comment | Drupal'), 'Page title is "Preview comment".');
   -    $this->assertText($edit['subject[0][value]'], 'Subject displayed.');
   -    $this->assertText($edit['comment_body[0][value]'], 'Comment displayed.');
   +    $this->assertTitle('Preview comment | Drupal');
   +    $this->assertText($edit['subject[0][value]']);
   +    $this->assertText($edit['comment_body[0][value]']);
   
   @@ -150,11 +150,11 @@ public function testCommentEditPreviewSave() {
   -    $this->assertTitle(t('Preview comment | Drupal'), 'Page title is "Preview comment".');
   -    $this->assertText($edit['subject[0][value]'], 'Subject displayed.');
   -    $this->assertText($edit['comment_body[0][value]'], 'Comment displayed.');
   -    $this->assertText($web_user->getAccountName(), 'Author displayed.');
   -    $this->assertText($expected_text_date, 'Date displayed.');
   +    $this->assertTitle('Preview comment | Drupal');
   +    $this->assertText($edit['subject[0][value]']);
   +    $this->assertText($edit['comment_body[0][value]']);
   +    $this->assertText($web_user->getAccountName());
   +    $this->assertText($expected_text_date);
   

   The changes to assertText calls are out of scope here.

2. +++ b/core/modules/search/tests/src/Functional/SearchPageTextTest.php
   @@ -77,7 +77,8 @@ public function testSearchText() {
        $title_source = 'Search for @keywords | Drupal';
   -    $this->assertTitle(t($title_source, ['@keywords' => Unicode::truncate($search_terms, 60, TRUE, TRUE)]), 'Search page title is correct');
   +    $title_source = 'Search for '.Unicode::truncate($search_terms, 60, TRUE, TRUE).' | Drupal';
   +    $this->assertTitle('Search for ' . Unicode::truncate($search_terms, 60, TRUE, TRUE) . ' | Drupal');
   

   This is ending up assigning $title_source twice, and not using it also.

if someone wants to test this on local with a different site name, then it would fail

No, it won't, because for every functional test a default Drupal installation is prepared and the test run on that, to avoid that the local site info leak in the test.

Thanks @mohrerao, this looks good, just there's a stray use statement left causing CS check failure.

Nit:

+++ b/core/modules/node/tests/src/Functional/NodeTitleTest.php
@@ -83,7 +83,7 @@ public function testNodeTitle() {
-    $this->assertTitle(0 . ' | Drupal', 'Page title is equal to 0.', 'Node');
+    $this->assertTitle(0 . ' | Drupal');

This could be just $this->assertTitle('0 | Drupal');, probably.

Thanks. This is outstanding:

FILE: ...ules/block_content/tests/src/Functional/BlockContentTypeTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Thanks! This patch is cleaning up Simpletest cruft from calls to AssertLegacyTrait::assertTitle and WebAssert::titleEquals - ensuring the first argument is always a string and no further arguments are passed in.

Prep for #3139412: Replace usages of deprecated AssertLegacyTrait::assertTitle().