Comments

extect created an issue. See original summary.

stefdewa’s picture

Category: Feature request » Task
Status: Active » Needs work
StatusFileSize
new54.42 KB
new736 bytes

It is not. Checked with module upgrade_status (screenshot added). Also started a patch that fixes the core_version_requirement and replaced the dependency on jquery.ui_sortable with core/sortable. This will break sorting because autcomplete_deluxe.js still needs an update to fix the deprecated sortable function and replace it with the new core alternative.

Reference : https://www.drupal.org/node/3084730

stefdewa’s picture

Status: Needs work » Needs review
StatusFileSize
new340 bytes

Woops! I misinterpreted the warning about jquery.ui_sortable. The core usages are removed, not the library itself. So this will only give a deprecation notice. EDIT this is wrong

Added a new patch that only adds the core_version_requirement.

stefdewa’s picture

Status: Needs review » Needs work

Been watching too many change records and crossed my wired. I was right in the #2

As stated in https://www.drupal.org/node/3084730
The core/jquery.ui.sortable library is deprecated in Drupal 8.8 and is removed from Drupal 9.

So jquery.ui_sortable still needs to be replaced with core/sortable and the JS code needs to be updated.

stefdewa’s picture

We could add https://www.drupal.org/project/jquery_ui_sortable as temporary replacement so we don't have to fix the JS code, but I will leave this for the maintainer to decide how to proceed.

vinay15’s picture

Assigned: Unassigned » vinay15
Issue tags: +DIACWMay2020
vinay15’s picture

Assigned: vinay15 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new1.7 KB
kristen pol’s picture

Presuming this is for Drupal 9 porting weekend since this was worked on during that time.

mrpauldriver’s picture

Status: Needs review » Reviewed & tested by the community

#7 Passes tests with Upgrade Status module

rajab natshah’s picture

Title: Drupal 9 ready? » Drupal 9 compatibility

rajab natshah’s picture

rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Reviewed & tested by the community » Fixed

Committed ... Thanks all :)

rajab natshah’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.