Is this module compatible with D9 already?
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | d9_readiness-3122933-7.patch | 1.7 KB | vinay15 |
| #3 | autocomplete_deluxe-D9_check-3122933-3.patch | 340 bytes | stefdewa |
| #2 | autocomplete_deluxe-D9_check-3122933-2.patch | 736 bytes | stefdewa |
| #2 | Screenshot 2020-04-24 at 11.13.35.png | 54.42 KB | stefdewa |
Comments
Comment #2
stefdewa commentedIt is not. Checked with module upgrade_status (screenshot added). Also started a patch that fixes the core_version_requirement and replaced the dependency on jquery.ui_sortable with core/sortable. This will break sorting because autcomplete_deluxe.js still needs an update to fix the deprecated sortable function and replace it with the new core alternative.
Reference : https://www.drupal.org/node/3084730
Comment #3
stefdewa commentedWoops! I misinterpreted the warning about jquery.ui_sortable. The core usages are removed, not the library itself. So this will only give a deprecation notice.EDIT this is wrongAdded a new patch that only adds the core_version_requirement.
Comment #4
stefdewa commentedBeen watching too many change records and crossed my wired. I was right in the #2
As stated in https://www.drupal.org/node/3084730
The core/jquery.ui.sortable library is deprecated in Drupal 8.8 and is removed from Drupal 9.
So jquery.ui_sortable still needs to be replaced with core/sortable and the JS code needs to be updated.
Comment #5
stefdewa commentedWe could add https://www.drupal.org/project/jquery_ui_sortable as temporary replacement so we don't have to fix the JS code, but I will leave this for the maintainer to decide how to proceed.
Comment #6
vinay15Comment #7
vinay15Comment #8
kristen polPresuming this is for Drupal 9 porting weekend since this was worked on during that time.
Comment #9
mrpauldriver commented#7 Passes tests with Upgrade Status module
Comment #10
rajab natshahComment #12
rajab natshahComment #13
rajab natshahComment #14
rajab natshahComment #15
rajab natshahCommitted ... Thanks all :)
Comment #16
rajab natshah