Closed (fixed)
Project:
Migrate Plus
Version:
6.0.x-dev
Component:
Plugins
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Mar 2020 at 15:30 UTC
Updated:
22 Apr 2022 at 11:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
rodrigoaguileraHere is a simple patch to demonstrate what I am referring to
Comment #4
rodrigoaguileraIt that a real failure?
Comment #5
rodrigoaguileraI include the patch for the 4.2 version for project that haven't updated yet
Comment #6
rodrigoaguilerawell, it doesn't apply to 4,x, only to 4.2.
Back to 5.x where is relevant
Comment #8
rodrigoaguileraOpened a MR to get some attention
Comment #9
heddnComment #10
matroskeenLet's try to address feedback in the merge request and add a test coverage.
Comment #11
matroskeenI put some test coverage for the new
operatorproperty, but it fails because of these lines:In the test example,
$result_valueislucumaand$valueislucu.That's why the result is removed.
Why do we have this? I haven't looked at the commit history yet. Perhaps the answer is there.
Comment #12
matroskeenI published a few more commits - it's ready for review.
Comment #14
matroskeenI self-reviewed it today and decided to go ahead and commit. If there are any suggestions/concerns, we can move them into a follow-up.
I'll also keep it open for backporting to 6.0 during the weekend so there is an opportunity to discuss if we can make it better.
Thanks!
Comment #15
matroskeenI don't know what happened After #12, but all tests are failing now. Trying a patch to add missing return types.
Comment #16
matroskeenOps, wrong file
Comment #17
matroskeenI reverted the last commit until we fix the test bot results.
Comment #18
matroskeenSince I can't figure out why the test results are not showing up, but the tests are passing (we can see it in the job details), here is a new patch that contains MR changes + #16.
Comment #20
matroskeenHere is a patch for 6.0.x version
Comment #22
matroskeenAlthough the message is "Build Successful", the tests are passing according to the Test Report.
This is committed to 8.x-5.x and 6.0.x.
Thanks!